[jira] [Commented] (CRUNCH-158) Make the initialization of DoFns in the in-memory impl consistent and have it support Counters

["Tim van Heugten (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CRUNCH-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567480#comment-13567480 ] 

Tim van Heugten commented on CRUNCH-158:
----------------------------------------

Hi, looks good to me.
I'm still in favor of making setContext() final (so the call to initialize is ensured), is that a different issue?
                
> Make the initialization of DoFns in the in-memory impl consistent and have it support Counters
> ----------------------------------------------------------------------------------------------
>
>                 Key: CRUNCH-158
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-158
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.4.0
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>         Attachments: CRUNCH-158.patch
>
>
> There is a discrepancy between how parallelDo initializes a DoFn for creating PCollections vs. PTables in the MemCollection implementation: we should be sure that we should initialize the methods consistently via calling setContext once and-only-once in each method.
> Fixing this also requires adding support for counters in the in-memory impl so that some tests in crunch-contrib don't fail.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira