[GitHub] [spark] soxofaan commented on pull request #39516: [SPARK-41989][PYTHON] Avoid breaking logging config from pyspark.pandas

["soxofaan (via GitHub)" <gi...@apache.org>]

soxofaan commented on PR #39516:
URL: https://github.com/apache/spark/pull/39516#issuecomment-1413491349

   @dongjoon-hyun 
   
   >  because some applications already rely on this `import logging`. After this patch, PySpark jobs fail.
   
   Do you really mean that removing `import logging` from `pyspark/pandas/__init__.py` is the cause of breakage? So you have code that does `from pyspark.pandas import logging` instead of just `import logging`? Or maybe you have `from pyspark.pandas import *`  and your implementation assumes this also imports `logging`? 
   
   
   Or do you mean that the removal of the `logging.warn()` call  (and it's hidden `logging.basicConfig` side-effect) is causing breakage?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org