[GitHub] clintropolis commented on a change in pull request #5957: Various changes

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #5957: Various changes
URL: https://github.com/apache/incubator-druid/pull/5957#discussion_r203922348
 
 

 ##########
 File path: processing/src/main/java/io/druid/segment/ColumnSelector.java
 ##########
 @@ -31,5 +31,5 @@
   List<String> getColumnNames();
 
   @Nullable
-  Column getColumn(String columnName);
+  ColumnHolder getColumn(String columnName);
 
 Review comment:
   Nit, maybe this should be called `getColumnHolder` or something to be a bit clearer since `ColumnHolder.getColumn` also exists and there are a handful of places that are effectively calling `selector.getColumn().getColumn()` which reads kind of funny.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@druid.apache.org
For additional commands, e-mail: dev-help@druid.apache.org