You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/09/23 00:36:38 UTC

[kudu-CR] [style] updates to prepare for cpplint upgrade

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23453


Change subject: [style] updates to prepare for cpplint upgrade
......................................................................

[style] updates to prepare for cpplint upgrade

There are no functional modifications in this changelist.

Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
---
M src/kudu/cfile/block_handle.h
M src/kudu/cfile/bshuf_block.h
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/plain_bitmap_block.h
M src/kudu/cfile/plain_block.h
M src/kudu/cfile/rle_block.h
M src/kudu/client/schema-internal.h
M src/kudu/client/shared_ptr.h
M src/kudu/common/columnblock-test-util.h
M src/kudu/common/row.h
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/ref_counted_replicate.h
M src/kudu/fs/fs-test-util.h
M src/kudu/rpc/retriable_rpc.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet_mem_trackers.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test-util.h
M src/kudu/thrift/client.h
M src/kudu/tserver/tablet_copy-test-base.h
M src/kudu/util/bloom_filter.cc
M src/kudu/util/cow_object.h
M src/kudu/util/file_cache-test-util.h
M src/kudu/util/interval_tree-inl.h
M src/kudu/util/memory/memory.h
M src/kudu/util/stopwatch.h
27 files changed, 38 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/23453/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Gerrit-Change-Number: 23453
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [style] updates to prepare for cpplint upgrade

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23453

to look at the new patch set (#2).

Change subject: [style] updates to prepare for cpplint upgrade
......................................................................

[style] updates to prepare for cpplint upgrade

There are no functional modifications in this changelist.

Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
---
M src/kudu/cfile/block_handle.h
M src/kudu/cfile/bshuf_block.h
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/plain_bitmap_block.h
M src/kudu/cfile/plain_block.h
M src/kudu/cfile/rle_block.h
M src/kudu/client/schema-internal.h
M src/kudu/client/shared_ptr.h
M src/kudu/common/columnblock-test-util.h
M src/kudu/common/row.h
M src/kudu/consensus/ref_counted_replicate.h
M src/kudu/fs/fs-test-util.h
M src/kudu/rpc/retriable_rpc.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet_mem_trackers.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test-util.h
M src/kudu/thrift/client.h
M src/kudu/tserver/tablet_copy-test-base.h
M src/kudu/util/bloom_filter.cc
M src/kudu/util/cow_object.h
M src/kudu/util/file_cache-test-util.h
M src/kudu/util/interval_tree-inl.h
M src/kudu/util/memory/memory.h
M src/kudu/util/stopwatch.h
26 files changed, 37 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/23453/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Gerrit-Change-Number: 23453
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [style] updates to prepare for cpplint upgrade

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23453 )

Change subject: [style] updates to prepare for cpplint upgrade
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Gerrit-Change-Number: 23453
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Sep 2025 04:11:12 +0000
Gerrit-HasComments: No

[kudu-CR] [style] updates to prepare for cpplint upgrade

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23453 )

Change subject: [style] updates to prepare for cpplint upgrade
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1840/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Gerrit-Change-Number: 23453
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Sep 2025 04:44:13 +0000
Gerrit-HasComments: No

[kudu-CR] [style] updates to prepare for cpplint upgrade

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23453 )

Change subject: [style] updates to prepare for cpplint upgrade
......................................................................

[style] updates to prepare for cpplint upgrade

There are no functional modifications in this changelist.

Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Reviewed-on: http://gerrit.cloudera.org:8080/23453
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/cfile/block_handle.h
M src/kudu/cfile/bshuf_block.h
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/plain_bitmap_block.h
M src/kudu/cfile/plain_block.h
M src/kudu/cfile/rle_block.h
M src/kudu/client/schema-internal.h
M src/kudu/client/shared_ptr.h
M src/kudu/common/columnblock-test-util.h
M src/kudu/common/row.h
M src/kudu/consensus/ref_counted_replicate.h
M src/kudu/fs/fs-test-util.h
M src/kudu/rpc/retriable_rpc.h
M src/kudu/rpc/rpc-test-base.h
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet_mem_trackers.h
M src/kudu/tablet/txn_metadata.h
M src/kudu/tablet/txn_participant-test-util.h
M src/kudu/thrift/client.h
M src/kudu/tserver/tablet_copy-test-base.h
M src/kudu/util/bloom_filter.cc
M src/kudu/util/cow_object.h
M src/kudu/util/file_cache-test-util.h
M src/kudu/util/interval_tree-inl.h
M src/kudu/util/memory/memory.h
M src/kudu/util/stopwatch.h
26 files changed, 37 insertions(+), 6 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Gerrit-Change-Number: 23453
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [style] updates to prepare for cpplint upgrade

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23453 )

Change subject: [style] updates to prepare for cpplint upgrade
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1840/


-- 
To view, visit http://gerrit.cloudera.org:8080/23453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Gerrit-Change-Number: 23453
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Sep 2025 02:35:10 +0000
Gerrit-HasComments: No

[kudu-CR] [style] updates to prepare for cpplint upgrade

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23453 )

Change subject: [style] updates to prepare for cpplint upgrade
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1838/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Gerrit-Change-Number: 23453
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Sep 2025 00:41:19 +0000
Gerrit-HasComments: No

[kudu-CR] [style] updates to prepare for cpplint upgrade

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23453 )

Change subject: [style] updates to prepare for cpplint upgrade
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1838/


-- 
To view, visit http://gerrit.cloudera.org:8080/23453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Gerrit-Change-Number: 23453
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Sep 2025 00:36:39 +0000
Gerrit-HasComments: No

[kudu-CR] [style] updates to prepare for cpplint upgrade

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23453 )

Change subject: [style] updates to prepare for cpplint upgrade
......................................................................


Patch Set 2: Verified+1

unrelated test failures


-- 
To view, visit http://gerrit.cloudera.org:8080/23453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Gerrit-Change-Number: 23453
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 23 Sep 2025 04:59:03 +0000
Gerrit-HasComments: No

[kudu-CR] [style] updates to prepare for cpplint upgrade

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [style] updates to prepare for cpplint upgrade
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I9349ee15f7de5dc173871fa0279705f849aad50d
Gerrit-Change-Number: 23453
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)