[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #862: unified account ut and fix account bugs

[GitBox <gi...@apache.org>]

tianxiaoliang commented on a change in pull request #862:
URL: https://github.com/apache/servicecomb-service-center/pull/862#discussion_r579585583



##########
File path: datasource/account.go
##########
@@ -32,9 +32,9 @@ var (
 // AccountManager contains the RBAC CRUD
 type AccountManager interface {
 	CreateAccount(ctx context.Context, a *rbac.Account) error
-	AccountExist(ctx context.Context, key string) (bool, error)
-	GetAccount(ctx context.Context, key string) (*rbac.Account, error)
-	ListAccount(ctx context.Context, key string) ([]*rbac.Account, int64, error)
-	DeleteAccount(ctx context.Context, key string) (bool, error)
-	UpdateAccount(ctx context.Context, key string, account *rbac.Account) error
+	AccountExist(ctx context.Context, name string) (bool, error)
+	GetAccount(ctx context.Context, name string) (*rbac.Account, error)
+	ListAccount(ctx context.Context) ([]*rbac.Account, int64, error)
+	DeleteAccount(ctx context.Context, name string) (bool, error)

Review comment:
       delete里的name先改成slice，为了以后能够支持批量删除，现在不必实现




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org