You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/11 02:03:00 UTC
[jira] [Commented] (ROCKETMQ-244) Message#putUserProperty uses ==
for String comparison
[ https://issues.apache.org/jira/browse/ROCKETMQ-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081505#comment-16081505 ]
ASF GitHub Bot commented on ROCKETMQ-244:
-----------------------------------------
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/131
[ROCKETMQ-244] BrokerData#selectBrokerAddr() picks the 1st element in the list of addresses
https://issues.apache.org/jira/browse/ROCKETMQ-244
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-244
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/131.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #131
----
commit 8c8029a24f46812911eba366b783ad8111c4e074
Author: shroman <rs...@yahoo.com>
Date: 2017-07-11T02:01:26Z
[ROCKETMQ-244] BrokerData#selectBrokerAddr() picks the 1st element in the list of addresses
https://issues.apache.org/jira/browse/ROCKETMQ-244
----
> Message#putUserProperty uses == for String comparison
> -----------------------------------------------------
>
> Key: ROCKETMQ-244
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-244
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-commons
> Affects Versions: 4.1.0-incubating
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
>
> {{value.trim() == ""}} won't be equal.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)