[GitHub] [flink] sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.

[GitBox <gi...@apache.org>]

sunjincheng121 commented on a change in pull request #8561: [FLINK-12588][python] Add TableSchema for Python Table API.
URL: https://github.com/apache/flink/pull/8561#discussion_r288808775
 
 

 ##########
 File path: flink-python/pyflink/table/table_descriptor.py
 ##########
 @@ -285,6 +289,10 @@ def line_delimiter(self, delimiter):
         self._j_csv = self._j_csv.lineDelimiter(delimiter)
         return self
 
+    def schema(self, schema):
+        self._j_csv = self._j_csv.schema(schema._j_table_schema)
 
 Review comment:
   I find that the JAVA have the follows JAVA DOC:
   ```
    /**
       * Sets the format schema with field names and the types. Required.
       * The table schema must not contain nested fields.
       *
       * This method overwrites existing fields added with [[field()]].
       *
       * @param schema the table schema
       */
   ```
   It's better to align the DOC, What to you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services