You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Antoine Toulme (JIRA)" <ji...@apache.org> on 2010/01/08 02:18:54 UTC
[jira] Created: (BUILDR-360) tag_name method is not present in Git
release task
tag_name method is not present in Git release task
--------------------------------------------------
Key: BUILDR-360
URL: https://issues.apache.org/jira/browse/BUILDR-360
Project: Buildr
Issue Type: Bug
Components: Core features
Affects Versions: 1.3.5
Reporter: Antoine Toulme
tag_name is not defined in the trunk and this code used to set the tag_name in the ODE Rakefile doesn't work with the trunk:
Release.find.tag_name = lambda { |version| "APACHE_ODE_#{version.upcase}" } if Release.find
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-360) tag_name method is not present in Git
release task
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme updated BUILDR-360:
----------------------------------
Attachment: BUILDR_360
Here is a patch that makes sure the tag_name can be set but warns that you should be using the class method.
> tag_name method is not present in Git release task
> --------------------------------------------------
>
> Key: BUILDR-360
> URL: https://issues.apache.org/jira/browse/BUILDR-360
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.3.5
> Reporter: Antoine Toulme
> Attachments: BUILDR_360
>
>
> tag_name is not defined in the trunk and this code used to set the tag_name in the ODE Rakefile doesn't work with the trunk:
> Release.find.tag_name = lambda { |version| "APACHE_ODE_#{version.upcase}" } if Release.find
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-360) tag_name method is not present in
Git release task
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797872#action_12797872 ]
Antoine Toulme commented on BUILDR-360:
---------------------------------------
Looks like the method went from being an instance method to a class method. That's good, less processing for configuring your project. At the same time, I would keep the behavior backward compatible. Let me see if I can make a patch with a deprecated warning.
> tag_name method is not present in Git release task
> --------------------------------------------------
>
> Key: BUILDR-360
> URL: https://issues.apache.org/jira/browse/BUILDR-360
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.3.5
> Reporter: Antoine Toulme
>
> tag_name is not defined in the trunk and this code used to set the tag_name in the ODE Rakefile doesn't work with the trunk:
> Release.find.tag_name = lambda { |version| "APACHE_ODE_#{version.upcase}" } if Release.find
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-360) tag_name method is not present in
Git release task
Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797862#action_12797862 ]
Antoine Toulme commented on BUILDR-360:
---------------------------------------
Here is the error I get when running "buildr" with the ODE Rakefile for the branch 1.x:
undefined method `tag_name=' for #<Buildr::GitRelease:0x15117cc0>
/Users/antoine/w/git/ode/Rakefile:169
/Users/antoine/w/git/ode/Rakefile:398:in `load'
> tag_name method is not present in Git release task
> --------------------------------------------------
>
> Key: BUILDR-360
> URL: https://issues.apache.org/jira/browse/BUILDR-360
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.3.5
> Reporter: Antoine Toulme
>
> tag_name is not defined in the trunk and this code used to set the tag_name in the ODE Rakefile doesn't work with the trunk:
> Release.find.tag_name = lambda { |version| "APACHE_ODE_#{version.upcase}" } if Release.find
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-360) tag_name method is not present in Git
release task
Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Boisvert resolved BUILDR-360.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.4
Patch committed. Thanks Antoine!
------------------------------------------------------------------------
r898892 | boisvert | 2010-01-13 11:11:55 -0800 (Wed, 13 Jan 2010) | 2 lines
BUILDR-360: Reintroduce tag_name instance method for Git release task for backward compatibility
> tag_name method is not present in Git release task
> --------------------------------------------------
>
> Key: BUILDR-360
> URL: https://issues.apache.org/jira/browse/BUILDR-360
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.3.5
> Reporter: Antoine Toulme
> Fix For: 1.4
>
> Attachments: BUILDR_360
>
>
> tag_name is not defined in the trunk and this code used to set the tag_name in the ODE Rakefile doesn't work with the trunk:
> Release.find.tag_name = lambda { |version| "APACHE_ODE_#{version.upcase}" } if Release.find
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.