[jira] Resolved: (AMQ-950) createConnector="false" has no effect on Tiger

["james strachan (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/activemq/browse/AMQ-950?page=all ]

james strachan resolved AMQ-950.
--------------------------------

    Resolution: Fixed

Patch applied - many thanks Renaud.

BTW could you double check my version of your patch works - I only create a connector if result != null and createConnector is true.



> createConnector="false" has no effect on Tiger
> ----------------------------------------------
>
>                 Key: AMQ-950
>                 URL: https://issues.apache.org/activemq/browse/AMQ-950
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 4.1
>         Environment: JDK 1.5.0_08
>            Reporter: Renaud Bruyeron
>            Priority: Minor
>             Fix For: 4.1
>
>
> On Tiger, activemq always creates a rmi connector on port 1099 no matter what I do with -Djavax.management... and <managementContext/>
> In particular, setting createConnector="false" should prevent AMQ from setting up its own connector, but it does not.
> The problem is in the findMBeanServer() method:
>             if (result == null && createMBeanServer) {
>                 result = createMBeanServer();
>             }
>             else {
>                 createConnector(result);
>             }
> result is not null on Tiger with useJmx="true", and createConnector is not protected by if(createConnector) like it is on the non-Tiger flow.
> The fix (I think) is simply to do this:
>             if (result == null && createMBeanServer) {
>                 result = createMBeanServer();
>             }
>             else {
>                 if(createConnector){
>                       createConnector(result);
>                 }
>             }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira