You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by "James Taylor (JIRA)" <ji...@apache.org> on 2015/05/16 00:54:02 UTC

[jira] [Commented] (PHOENIX-1979) FamilyOnlyFilter should test for != INCLUDE instead of == SKIP

    [ https://issues.apache.org/jira/browse/PHOENIX-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546325#comment-14546325 ] 

James Taylor commented on PHOENIX-1979:
---------------------------------------

+1 to the patch. [~jesse_yates] - I don't see a reference to FamilyOnlyFilter anywhere but in this test - Can we just remove the test and the filter in that case?

> FamilyOnlyFilter should test for != INCLUDE instead of == SKIP
> --------------------------------------------------------------
>
>                 Key: PHOENIX-1979
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1979
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 5.0.0, 4.3.0, 4.4.0
>
>         Attachments: PHOENIX-1979.patch
>
>
> TestFamilyOnlyFilter wants to confirm that the HBase FamilyFilter filters out cells as expected, but is unnecessarily brittle in that it checks for a specific return hint (SKIP) when it should just be checking that the cell was not included (INCLUDE). This breaks after HBASE-13122, which optimizes the FamilyFilter return hints.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)