You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2026/06/05 07:24:59 UTC
[PR] chore(deps): bump react-router-dom from 5.3.4 to 7.16.0 in /superset-frontend [superset]
dependabot[bot] opened a new pull request, #40799:
URL: https://github.com/apache/superset/pull/40799
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 5.3.4 to 7.16.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/remix-run/react-router/releases">react-router-dom's releases</a>.</em></p>
<blockquote>
<h2>v7.1.3</h2>
<p>See the changelog for release notes: <a href="https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v713">https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v713</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md">react-router-dom's changelog</a>.</em></p>
<blockquote>
<h2>v7.16.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Remove stale/invalid <code>unpkg</code> field from <code>package.json</code>. This was removed from other packages with the release of v7 but missed in the <code>react-router-dom</code> re-export package (<a href="https://redirect.github.com/remix-run/react-router/pull/15075">#15075</a>)</li>
<li>Updated dependencies:
<ul>
<li><a href="https://github.com/remix-run/react-router/releases/tag/react-router@7.16.0"><code>react-router@7.16.0</code></a></li>
</ul>
</li>
</ul>
<h2>v7.15.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><a href="https://github.com/remix-run/react-router/releases/tag/react-router@7.15.1"><code>react-router@7.15.1</code></a></li>
</ul>
</li>
</ul>
<h2>v7.15.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><a href="https://github.com/remix-run/react-router/releases/tag/react-router@7.15.0"><code>react-router@7.15.0</code></a></li>
</ul>
</li>
</ul>
<h2>v7.14.2</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><a href="https://github.com/remix-run/react-router/releases/tag/react-router@7.14.2"><code>react-router@7.14.2</code></a></li>
</ul>
</li>
</ul>
<h2>v7.14.1</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><a href="https://github.com/remix-run/react-router/releases/tag/react-router@7.14.1"><code>react-router@7.14.1</code></a></li>
</ul>
</li>
</ul>
<h2>7.14.0</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.14.0</code></li>
</ul>
</li>
</ul>
<h2>7.13.2</h2>
<h3>Patch Changes</h3>
<ul>
<li>Updated dependencies:
<ul>
<li><code>react-router@7.13.2</code></li>
</ul>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/remix-run/react-router/commit/8984d23f86ca7ae5655711744b77816090bda4e6"><code>8984d23</code></a> Release v7.16.0 (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/15105">#15105</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/3ed77afcde0ad9aea79f1afe5f05a700b201f289"><code>3ed77af</code></a> chore: format</li>
<li><a href="https://github.com/remix-run/react-router/commit/e96962bc6159a2290632849b55872a3878753342"><code>e96962b</code></a> fix: remove stale unpkg field from react-router-dom (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/15075">#15075</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/587d08fca6ca61e00f44c1eda95bf6e6a9ab76ef"><code>587d08f</code></a> Release v7.15.1 (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/15038">#15038</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/97c8de79c38f107acd15f74d8295c7bf75894a5d"><code>97c8de7</code></a> Release v7.15.0 (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/15018">#15018</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/cf1d25003aa1217dc21c16e95d483601940ae9af"><code>cf1d250</code></a> Release v7.14.2 (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14993">#14993</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/197674ba9fc1b72b452e17894e5e783bdab7a087"><code>197674b</code></a> Release 7.14.1 (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14973">#14973</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/a87774f997d8ba497c97562840f0766250c3e4ce"><code>a87774f</code></a> Add new release process (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14916">#14916</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/e31077b0c380d9764dbced4c753e9ff99387045d"><code>e31077b</code></a> chore: Update version for release (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14945">#14945</a>)</li>
<li><a href="https://github.com/remix-run/react-router/commit/6683e85a9d7d607a45a3f6374afcc598a474f602"><code>6683e85</code></a> chore: Update version for release (pre) (<a href="https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom/issues/14943">#14943</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/remix-run/react-router/commits/react-router-dom@7.16.0/packages/react-router-dom">compare view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a href="https://www.npmjs.com/~GitHub%20Actions">GitHub Actions</a>, a new releaser for react-router-dom since your current version.</p>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump react-router-dom from 5.3.4 to 7.16.0 in /superset-frontend [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40799:
URL: https://github.com/apache/superset/pull/40799#issuecomment-4629174224
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump react-router-dom from 5.3.4 to 7.16.0 in /superset-frontend [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber closed pull request #40799: chore(deps): bump react-router-dom from 5.3.4 to 7.16.0 in /superset-frontend
URL: https://github.com/apache/superset/pull/40799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump react-router-dom from 5.3.4 to 7.16.0 in /superset-frontend [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #40799:
URL: https://github.com/apache/superset/pull/40799#issuecomment-4662023136
@dependabot ignore this dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump react-router-dom from 5.3.4 to 7.16.0 in /superset-frontend [superset]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] commented on PR #40799:
URL: https://github.com/apache/superset/pull/40799#issuecomment-4662023809
OK, I won't notify you about react-router-dom again, unless you re-open this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump react-router-dom from 5.3.4 to 7.16.0 in /superset-frontend [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #40799:
URL: https://github.com/apache/superset/pull/40799#issuecomment-4654997203
I dug into this one to see whether it could be made landable. Short answer: **not as a mechanical Dependabot bump** — `react-router-dom` v5→v7 is effectively a full rewrite (v5→v6 changed nearly every API; v7 then dropped `react-router-dom` in favor of `react-router` and made the old `future` flags mandatory). I've rebased the branch onto current `master` so the dep bump is no longer stale, but I'm intentionally **not** force-pushing a code conversion, because there is no compilable partial subset (more on that below).
### Why this is all-or-nothing
v7's `react-router-dom` is just `export * from 'react-router'` and the v5 symbols we rely on are gone entirely: `Switch`, `Redirect`, `useHistory`, and `withRouter` no longer exist. The instant the resolved dependency is v7, **every** importing file fails at module resolution simultaneously, so you can't convert "half" the files and still have the bundle build. A coherent landing has to convert all call sites in one atomic change.
### Scope (call sites in `superset-frontend/src`)
- **86 files** import from `react-router(-dom)` — **58 production**, **28 test**.
- `useHistory` → `useNavigate`: **38 files** (30 prod / 8 test). Underlying method usage: `history.push` ×41, `history.replace` ×15, `history.location` ×10, `history.goBack`/`history.go` ×2.
- `<Switch>` → `<Routes>` + `<Route component=>`/`children` → `<Route element={}>`: central setup in `src/views/App.tsx` and `src/embedded/index.tsx`.
- `<Redirect>` → `<Navigate>`: `src/SqlLab/components/App/index.tsx` (note the default flips from `replace` to `push`).
- `withRouter` → hooks: 2 prod files (+ `RouteComponentProps` types).
- `<NavLink activeClassName>` → `className={({isActive})=>…}`: 1 file.
- `<Router history={memoryHistory}>` test-wrapper pattern (gone in v6+): **5+ test files plus the shared `spec/helpers/testing-library.tsx`** — all need `MemoryRouter`/`createMemoryRouter`.
### The two parts that are *not* mechanical (real rewrites)
1. **`history.block()` / `history.listen()` have no v6/v7 equivalent.** `src/hooks/useUnsavedChangesPrompt/index.ts` (the unsaved-changes guard) uses `history.block`, and `src/pages/Chart/index.tsx` uses `history.listen`. Replacing these means `useBlocker`, which requires a **data router** (`createBrowserRouter` + `RouterProvider`) — i.e. converting our top-level `<BrowserRouter>` + route-array setup in `App.tsx` to a data-router config. That's an architectural change, not a find-and-replace.
2. **Exact-matching default.** v5 `<Route path>` matched by prefix; v6/v7 match exactly. Our routes (e.g. `/dashboard/list/`, `/chart/add`) and the `isFrontendRoute` prefix logic in `src/views/routes.tsx` need `/*` splats and verification per route, and v7's mandatory `v7_relativeSplatPath` changes relative-link resolution under splats.
### Other required cleanups
- Drop `@types/react-router-dom@^5.3.3` (devDep) — v7 ships its own types and the v5 types will conflict.
- The direct `history@^5.3.0` dep is used mostly for the `History`/`Location`/`Action` types (`hydrate.ts`, `chartAction.ts`, `useUnsavedChangesPrompt`, `pages/Chart`); re-point these to v7's own types or keep `history` only as a type source.
- v7 wants Node 20+/React 18+ (we're on React 18, fine).
### Suggested path to actually land it
1. **PR 1 (prep, lands today):** bump to `react-router-dom@6` with all `future` flags on, do the mechanical codemods (`Switch`→`Routes`, `component`→`element`, `useHistory`→`useNavigate`, `Redirect`→`Navigate`, `withRouter`→hooks, NavLink, and the test `<Router history>`→`MemoryRouter` wrappers incl. the shared test helper), and migrate `App.tsx`/`embedded` to a data router so `useBlocker` replaces `history.block`/`listen`.
2. **PR 2 (trivial):** bump 6→7, flip imports to `react-router`, drop `@types/react-router-dom`. With the v6 `future` flags already enabled, this step is nearly a no-op.
I'd rather split it this way than drop one giant high-risk diff on top of the routing core. Happy to take the v6 prep PR myself. Leaving this PR open with the rebased bump for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org