You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/09/30 19:08:34 UTC
[PR] fix(server): prevent panic when the cleaner removes expired tokens [iggy]
hubcio opened a new pull request, #4364:
URL: https://github.com/apache/iggy/pull/4364
The expired-token cleaner deletes through consensus under the
reserved client id 0, which never registers. Since #3753 made
commit_reply unconditional, its assert on id 0 panicked shard 0 on
every such commit: a solo node crashed once per expired token, and
a cluster lost the primary and a backup on the same op.
commit_reply now returns NoEntry for the reserved id, as
commit_request already does, so one check covers every commit path.
The commit loop also skips the wire reply for that id: after a view
change or a boot re-pipeline the entry has no in-process sender,
and the send only logged a false error.
Fixes #4361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server): prevent panic when the cleaner removes expired tokens [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4364:
URL: https://github.com/apache/iggy/pull/4364#issuecomment-5920106966
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/4364?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `77.90698%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 71.14%. Comparing base ([`8f93cad`](https://app.codecov.io/gh/apache/iggy/commit/8f93cad89506c10d6ba7fbffe9314870a93385a1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2f0877e`](https://app.codecov.io/gh/apache/iggy/commit/2f0877eb623eddff56ea3dca983a14f1fcfbbdde?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4364?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [core/metadata/src/impls/metadata.rs](https://app.codecov.io/gh/apache/iggy/pull/4364?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fimpls%2Fmetadata.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvaW1wbHMvbWV0YWRhdGEucnM=) | 71.64% | [19 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4364 +/- ##
=============================================
- Coverage 87.87% 71.14% -16.73%
Complexity 1577 1577
=============================================
Files 1290 1288 -2
Lines 228775 203807 -24968
Branches 192116 167167 -24949
=============================================
- Hits 201034 145001 -56033
- Misses 23026 54147 +31121
+ Partials 4715 4659 -56
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/4364/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/4364/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.43% <77.90%> (-20.55%)` | :arrow_down: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/4364/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.73% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/4364/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.45% <ø> (+0.01%)` | :arrow_up: |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/4364/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `91.24% <ø> (+0.21%)` | :arrow_up: |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/4364/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.67% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/4364/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.57% <ø> (ø)` | |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/4364/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.30% <ø> (ø)` | |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4364?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/consensus/src/client\_table.rs](https://app.codecov.io/gh/apache/iggy/pull/4364?src=pr&el=tree&filepath=core%2Fconsensus%2Fsrc%2Fclient_table.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25zZW5zdXMvc3JjL2NsaWVudF90YWJsZS5ycw==) | `91.89% <100.00%> (+0.05%)` | :arrow_up: |
| [core/consensus/src/lib.rs](https://app.codecov.io/gh/apache/iggy/pull/4364?src=pr&el=tree&filepath=core%2Fconsensus%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25zZW5zdXMvc3JjL2xpYi5ycw==) | `0.00% <ø> (ø)` | |
| [core/metadata/src/impls/metadata.rs](https://app.codecov.io/gh/apache/iggy/pull/4364?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fimpls%2Fmetadata.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvaW1wbHMvbWV0YWRhdGEucnM=) | `91.01% <71.64%> (+0.52%)` | :arrow_up: |
... and [362 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/4364/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server): prevent panic when the cleaner removes expired tokens [iggy]
Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz merged PR #4364:
URL: https://github.com/apache/iggy/pull/4364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org