You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/07/20 15:03:46 UTC

[commons-codec] branch master updated (9253700 -> 9969e7b)

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git.


    from 9253700  Remove trailing white spaces.
     new 3e6fb93  Use final.
     new fe39ffc  Remove unnecessary type casts.
     new 9969e7b  Prepare for the next release.

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 CONTRIBUTING.md                                    |  6 +--
 NOTICE.txt                                         |  2 +-
 README.md                                          | 12 +++---
 .../java/org/apache/commons/codec/binary/Hex.java  |  2 +-
 .../apache/commons/codec/digest/MurmurHash2.java   |  2 +-
 .../apache/commons/codec/digest/MurmurHash3.java   |  4 +-
 src/site/xdoc/download_codec.xml                   | 44 +++++++++++-----------
 src/site/xdoc/issue-tracking.xml                   |  4 +-
 src/site/xdoc/mail-lists.xml                       | 30 +++++++--------
 9 files changed, 55 insertions(+), 51 deletions(-)


[commons-codec] 01/03: Use final.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git

commit 3e6fb93250fb951ccd3b9597cd19b1c2243a77b1
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jul 20 10:55:28 2019 -0400

    Use final.
---
 src/main/java/org/apache/commons/codec/binary/Hex.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/commons/codec/binary/Hex.java b/src/main/java/org/apache/commons/codec/binary/Hex.java
index 4129a5f..0097f09 100644
--- a/src/main/java/org/apache/commons/codec/binary/Hex.java
+++ b/src/main/java/org/apache/commons/codec/binary/Hex.java
@@ -252,7 +252,7 @@ public class Hex implements BinaryEncoder, BinaryDecoder {
         if (byteBuffer.hasArray()) {
             return byteBuffer.array();
         }
-        byte[] byteArray = new byte[byteBuffer.remaining()];
+        final byte[] byteArray = new byte[byteBuffer.remaining()];
         byteBuffer.get(byteArray);
         return byteArray;
     }


[commons-codec] 03/03: Prepare for the next release.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git

commit 9969e7b317777e151646923d302e856b163ba224
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jul 20 11:03:42 2019 -0400

    Prepare for the next release.
---
 CONTRIBUTING.md                  |  6 +++---
 NOTICE.txt                       |  2 +-
 README.md                        | 12 ++++++-----
 src/site/xdoc/download_codec.xml | 44 +++++++++++++++++++++-------------------
 src/site/xdoc/issue-tracking.xml |  4 ++--
 src/site/xdoc/mail-lists.xml     | 30 +++++++++++++--------------
 6 files changed, 51 insertions(+), 47 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index fe1dfbd..d33a45a 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -25,7 +25,7 @@
  | commons-build-plugin/trunk/src/main/resources/commons-xdoc-templates |
  +======================================================================+
  |                                                                      |
- | 1) Re-generate using: mvn commons:contributing-md                    |
+ | 1) Re-generate using: mvn commons-build:contributing-md              |
  |                                                                      |
  | 2) Set the following properties in the component's pom:              |
  |    - commons.jira.id  (required, alphabetic, upper case)             |
@@ -50,7 +50,7 @@ Getting Started
 
 + Make sure you have a [JIRA account](https://issues.apache.org/jira/).
 + Make sure you have a [GitHub account](https://github.com/signup/free).
-+ If you're planning to implement a new feature it makes sense to discuss you're changes on the [dev list](https://commons.apache.org/mail-lists.html) first. This way you can make sure you're not wasting your time on something that isn't considered to be in Apache Commons Codec's scope.
++ If you're planning to implement a new feature it makes sense to discuss your changes on the [dev list](https://commons.apache.org/mail-lists.html) first. This way you can make sure you're not wasting your time on something that isn't considered to be in Apache Commons Codec's scope.
 + Submit a [Jira Ticket][jira] for your issue, assuming one does not already exist.
   + Clearly describe the issue including steps to reproduce when it is a bug.
   + Make sure you fill in the earliest version that you know has the issue.
@@ -107,7 +107,7 @@ Additional Resources
 + [Apache Commons Codec JIRA project page][jira]
 + [Contributor License Agreement][cla]
 + [General GitHub documentation](https://help.github.com/)
-+ [GitHub pull request documentation](https://help.github.com/send-pull-requests/)
++ [GitHub pull request documentation](https://help.github.com/articles/creating-a-pull-request/)
 + [Apache Commons Twitter Account](https://twitter.com/ApacheCommons)
 + `#apache-commons` IRC channel on `irc.freenode.net`
 
diff --git a/NOTICE.txt b/NOTICE.txt
index 89de208..7144883 100644
--- a/NOTICE.txt
+++ b/NOTICE.txt
@@ -2,7 +2,7 @@ Apache Commons Codec
 Copyright 2002-2019 The Apache Software Foundation
 
 This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
+The Apache Software Foundation (https://www.apache.org/).
 
 src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.java
 contains test data from http://aspell.net/test/orig/batch0.tab.
diff --git a/README.md b/README.md
index 669db91..6ce6146 100644
--- a/README.md
+++ b/README.md
@@ -25,7 +25,7 @@
  | commons-build-plugin/trunk/src/main/resources/commons-xdoc-templates |
  +======================================================================+
  |                                                                      |
- | 1) Re-generate using: mvn commons:readme-md                          |
+ | 1) Re-generate using: mvn commons-build:readme-md                    |
  |                                                                      |
  | 2) Set the following properties in the component's pom:              |
  |    - commons.componentid (required, alphabetic, lower case)          |
@@ -43,8 +43,10 @@
 Apache Commons Codec
 ===================
 
-[![Build Status](https://travis-ci.org/apache/commons-codec.svg?branch=trunk)](https://travis-ci.org/apache/commons-codec)
-[![Coverage Status](https://coveralls.io/repos/apache/commons-codec/badge.svg?branch=trunk)](https://coveralls.io/r/apache/commons-codec)
+[![Build Status](https://travis-ci.org/apache/commons-codec.svg)](https://travis-ci.org/apache/commons-codec)
+[![Coverage Status](https://coveralls.io/repos/apache/commons-codec/badge.svg)](https://coveralls.io/r/apache/commons-codec)
+[![Maven Central](https://maven-badges.herokuapp.com/maven-central/commons-codec/commons-codec/badge.svg)](https://maven-badges.herokuapp.com/maven-central/commons-codec/commons-codec/)
+[![Javadocs](https://javadoc.io/badge/commons-codec/commons-codec/1.13.svg)](https://javadoc.io/doc/commons-codec/commons-codec/1.13)
 
 The Apache Commons Codec package contains simple encoder and decoders for
      various formats such as Base64 and Hexadecimal.  In addition to these
@@ -55,7 +57,7 @@ Documentation
 -------------
 
 More information can be found on the [Apache Commons Codec homepage](https://commons.apache.org/proper/commons-codec).
-The [Javadoc](https://commons.apache.org/proper/commons-codec/javadocs/api-release) can be browsed.
+The [Javadoc](https://commons.apache.org/proper/commons-codec/apidocs) can be browsed.
 Questions related to the usage of Apache Commons Codec should be posted to the [user mailing list][ml].
 
 Where can I get the latest release?
@@ -68,7 +70,7 @@ Alternatively you can pull it from the central Maven repositories:
 <dependency>
   <groupId>commons-codec</groupId>
   <artifactId>commons-codec</artifactId>
-  <version>1.12</version>
+  <version>1.13</version>
 </dependency>
 ```
 
diff --git a/src/site/xdoc/download_codec.xml b/src/site/xdoc/download_codec.xml
index d4c9f6c..1a1aafe 100644
--- a/src/site/xdoc/download_codec.xml
+++ b/src/site/xdoc/download_codec.xml
@@ -26,22 +26,24 @@ limitations under the License.
  | commons-build-plugin/trunk/src/main/resources/commons-xdoc-templates |
  +======================================================================+
  |                                                                      |
- | 1) Re-generate using: mvn commons:download-page                      |
+ | 1) Re-generate using: mvn commons-build:download-page                |
  |                                                                      |
  | 2) Set the following properties in the component's pom:              |
- |    - commons.componentid (required, alphabetic, lower case)          |
+ |    - commons.componentid     (required, alphabetic, lower case)      |
  |    - commons.release.version (required)                              |
  |    - commons.release.name    (required)                              |
  |    - commons.binary.suffix   (optional)                              |
  |      (defaults to "-bin", set to "" for pre-maven2 releases)         |
  |    - commons.release.desc    (optional)                              |
  |    - commons.release.subdir  (optional)                              |
+ |    - commons.release.hash    (optional, lowercase, default sha512)   |
  |                                                                      |
- |    - commons.release.2/3.version       (conditional)                 |
- |    - commons.release.2/3.name          (conditional)                 |
- |    - commons.release.2/3.binary.suffix (optional)                    |
- |    - commons.release.2/3.desc          (optional)                    |
- |    - commons.release.2/3.subdir        (optional)                    |
+ |    - commons.release.[234].version       (conditional)               |
+ |    - commons.release.[234].name          (conditional)               |
+ |    - commons.release.[234].binary.suffix (optional)                  |
+ |    - commons.release.[234].desc          (optional)                  |
+ |    - commons.release.[234].subdir        (optional)                  |
+ |    - commons.release.[234].hash       (optional, lowercase, [sha512])|
  |                                                                      |
  | 3) Example Properties                                                |
  |    (commons.release.name inherited by parent:                        |
@@ -64,7 +66,7 @@ limitations under the License.
     <subsection name="Using a Mirror">
       <p>
         We recommend you use a mirror to download our release
-        builds, but you <strong>must</strong> <a href="http://www.apache.org/info/verification.html">verify the integrity</a> of
+        builds, but you <strong>must</strong> <a href="https://www.apache.org/info/verification.html">verify the integrity</a> of
         the downloaded files using signatures downloaded from our main
         distribution directories. Recent releases (48 hours) may not yet
         be available from all the mirrors.
@@ -111,32 +113,32 @@ limitations under the License.
       </p>
     </subsection>
     </section>
-    <section name="Apache Commons Codec 1.12 ">
+    <section name="Apache Commons Codec 1.13 ">
       <subsection name="Binaries">
         <table>
           <tr>
-              <td><a href="[preferred]/commons/codec/binaries/commons-codec-1.12-bin.tar.gz">commons-codec-1.12-bin.tar.gz</a></td>
-              <td><a href="https://www.apache.org/dist/commons/codec/binaries/commons-codec-1.12-bin.tar.gz.sha512">sha512</a></td>
-              <td><a href="https://www.apache.org/dist/commons/codec/binaries/commons-codec-1.12-bin.tar.gz.asc">pgp</a></td>
+              <td><a href="[preferred]/commons/codec/binaries/commons-codec-1.13-bin.tar.gz">commons-codec-1.13-bin.tar.gz</a></td>
+              <td><a href="https://www.apache.org/dist/commons/codec/binaries/commons-codec-1.13-bin.tar.gz.sha512">sha512</a></td>
+              <td><a href="https://www.apache.org/dist/commons/codec/binaries/commons-codec-1.13-bin.tar.gz.asc">pgp</a></td>
           </tr>
           <tr>
-              <td><a href="[preferred]/commons/codec/binaries/commons-codec-1.12-bin.zip">commons-codec-1.12-bin.zip</a></td>
-              <td><a href="https://www.apache.org/dist/commons/codec/binaries/commons-codec-1.12-bin.zip.sha512">sha512</a></td>
-              <td><a href="https://www.apache.org/dist/commons/codec/binaries/commons-codec-1.12-bin.zip.asc">pgp</a></td>
+              <td><a href="[preferred]/commons/codec/binaries/commons-codec-1.13-bin.zip">commons-codec-1.13-bin.zip</a></td>
+              <td><a href="https://www.apache.org/dist/commons/codec/binaries/commons-codec-1.13-bin.zip.sha512">sha512</a></td>
+              <td><a href="https://www.apache.org/dist/commons/codec/binaries/commons-codec-1.13-bin.zip.asc">pgp</a></td>
           </tr>
         </table>
       </subsection>
       <subsection name="Source">
         <table>
           <tr>
-              <td><a href="[preferred]/commons/codec/source/commons-codec-1.12-src.tar.gz">commons-codec-1.12-src.tar.gz</a></td>
-              <td><a href="https://www.apache.org/dist/commons/codec/source/commons-codec-1.12-src.tar.gz.sha512">sha512</a></td>
-              <td><a href="https://www.apache.org/dist/commons/codec/source/commons-codec-1.12-src.tar.gz.asc">pgp</a></td>
+              <td><a href="[preferred]/commons/codec/source/commons-codec-1.13-src.tar.gz">commons-codec-1.13-src.tar.gz</a></td>
+              <td><a href="https://www.apache.org/dist/commons/codec/source/commons-codec-1.13-src.tar.gz.sha512">sha512</a></td>
+              <td><a href="https://www.apache.org/dist/commons/codec/source/commons-codec-1.13-src.tar.gz.asc">pgp</a></td>
           </tr>
           <tr>
-              <td><a href="[preferred]/commons/codec/source/commons-codec-1.12-src.zip">commons-codec-1.12-src.zip</a></td>
-              <td><a href="https://www.apache.org/dist/commons/codec/source/commons-codec-1.12-src.zip.sha512">sha512</a></td>
-              <td><a href="https://www.apache.org/dist/commons/codec/source/commons-codec-1.12-src.zip.asc">pgp</a></td>
+              <td><a href="[preferred]/commons/codec/source/commons-codec-1.13-src.zip">commons-codec-1.13-src.zip</a></td>
+              <td><a href="https://www.apache.org/dist/commons/codec/source/commons-codec-1.13-src.zip.sha512">sha512</a></td>
+              <td><a href="https://www.apache.org/dist/commons/codec/source/commons-codec-1.13-src.zip.asc">pgp</a></td>
           </tr>
         </table>
       </subsection>
diff --git a/src/site/xdoc/issue-tracking.xml b/src/site/xdoc/issue-tracking.xml
index 8babe32..b5fb328 100644
--- a/src/site/xdoc/issue-tracking.xml
+++ b/src/site/xdoc/issue-tracking.xml
@@ -26,7 +26,7 @@ limitations under the License.
  | commons-build-plugin/trunk/src/main/resources/commons-xdoc-templates |
  +======================================================================+
  |                                                                      |
- | 1) Re-generate using: mvn commons:jira-page                          |
+ | 1) Re-generate using: mvn commons-build:jira-page                    |
  |                                                                      |
  | 2) Set the following properties in the component's pom:              |
  |    - commons.jira.id  (required, alphabetic, upper case)             |
@@ -86,7 +86,7 @@ limitations under the License.
 
       <p>
       For more information on subversion and creating patches see the
-      <a href="http://www.apache.org/dev/contributors.html">Apache Contributors Guide</a>.
+      <a href="https://www.apache.org/dev/contributors.html">Apache Contributors Guide</a>.
       </p>
 
       <p>
diff --git a/src/site/xdoc/mail-lists.xml b/src/site/xdoc/mail-lists.xml
index 6d4727d..1d2ce1e 100644
--- a/src/site/xdoc/mail-lists.xml
+++ b/src/site/xdoc/mail-lists.xml
@@ -26,7 +26,7 @@ limitations under the License.
  | commons-build-plugin/trunk/src/main/resources/commons-xdoc-templates |
  +======================================================================+
  |                                                                      |
- | 1) Re-generate using: mvn commons:mail-page                          |
+ | 1) Re-generate using: mvn commons-build:mail-page                    |
  |                                                                      |
  | 2) Set the following properties in the component's pom:              |
  |    - commons.componentid (required, alphabetic, lower case)          |
@@ -106,9 +106,9 @@ limitations under the License.
           <td><a href="mailto:user-unsubscribe@commons.apache.org">Unsubscribe</a></td>
           <td><a href="mailto:user@commons.apache.org?subject=[codec]">Post</a></td>
           <td><a href="https://mail-archives.apache.org/mod_mbox/commons-user/">mail-archives.apache.org</a></td>
-          <td><a href="http://markmail.org/list/org.apache.commons.users/">markmail.org</a><br />
-              <a href="http://www.mail-archive.com/user@commons.apache.org/">www.mail-archive.com</a><br />
-              <a href="http://news.gmane.org/gmane.comp.jakarta.commons.devel">news.gmane.org</a>
+          <td><a href="https://markmail.org/list/org.apache.commons.users/">markmail.org</a><br />
+              <a href="https://www.mail-archive.com/user@commons.apache.org/">www.mail-archive.com</a><br />
+              <a href="https://news.gmane.org/gmane.comp.jakarta.commons.devel">news.gmane.org</a>
           </td>
         </tr>
 
@@ -124,9 +124,9 @@ limitations under the License.
           <td><a href="mailto:dev-unsubscribe@commons.apache.org">Unsubscribe</a></td>
           <td><a href="mailto:dev@commons.apache.org?subject=[codec]">Post</a></td>
           <td><a href="https://mail-archives.apache.org/mod_mbox/commons-dev/">mail-archives.apache.org</a></td>
-          <td><a href="http://markmail.org/list/org.apache.commons.dev/">markmail.org</a><br />
-              <a href="http://www.mail-archive.com/dev@commons.apache.org/">www.mail-archive.com</a><br />
-              <a href="http://news.gmane.org/gmane.comp.jakarta.commons.devel">news.gmane.org</a>
+          <td><a href="https://markmail.org/list/org.apache.commons.dev/">markmail.org</a><br />
+              <a href="https://www.mail-archive.com/dev@commons.apache.org/">www.mail-archive.com</a><br />
+              <a href="https://news.gmane.org/gmane.comp.jakarta.commons.devel">news.gmane.org</a>
           </td>
         </tr>
 
@@ -142,8 +142,8 @@ limitations under the License.
           <td><a href="mailto:issues-unsubscribe@commons.apache.org">Unsubscribe</a></td>
           <td><i>read only</i></td>
           <td><a href="https://mail-archives.apache.org/mod_mbox/commons-issues/">mail-archives.apache.org</a></td>
-          <td><a href="http://markmail.org/list/org.apache.commons.issues/">markmail.org</a><br />
-              <a href="http://www.mail-archive.com/issues@commons.apache.org/">www.mail-archive.com</a>
+          <td><a href="https://markmail.org/list/org.apache.commons.issues/">markmail.org</a><br />
+              <a href="https://www.mail-archive.com/issues@commons.apache.org/">www.mail-archive.com</a>
           </td>
         </tr>
 
@@ -159,8 +159,8 @@ limitations under the License.
           <td><a href="mailto:commits-unsubscribe@commons.apache.org">Unsubscribe</a></td>
           <td><i>read only</i></td>
           <td><a href="https://mail-archives.apache.org/mod_mbox/commons-commits/">mail-archives.apache.org</a></td>
-          <td><a href="http://markmail.org/list/org.apache.commons.commits/">markmail.org</a><br />
-              <a href="http://www.mail-archive.com/commits@commons.apache.org/">www.mail-archive.com</a>
+          <td><a href="https://markmail.org/list/org.apache.commons.commits/">markmail.org</a><br />
+              <a href="https://www.mail-archive.com/commits@commons.apache.org/">www.mail-archive.com</a>
           </td>
         </tr>
 
@@ -192,10 +192,10 @@ limitations under the License.
           <td><a class="externalLink" href="mailto:announce-unsubscribe@apache.org">Unsubscribe</a></td>
           <td><i>read only</i></td>
           <td><a class="externalLink" href="https://mail-archives.apache.org/mod_mbox/www-announce/">mail-archives.apache.org</a></td>
-          <td><a class="externalLink" href="http://markmail.org/list/org.apache.announce/">markmail.org</a><br />
-              <a class="externalLink" href="http://old.nabble.com/Apache-News-and-Announce-f109.html">old.nabble.com</a><br />
-              <a class="externalLink" href="http://www.mail-archive.com/announce@apache.org/">www.mail-archive.com</a><br />
-              <a class="externalLink" href="http://news.gmane.org/gmane.comp.apache.announce">news.gmane.org</a>
+          <td><a class="externalLink" href="https://markmail.org/list/org.apache.announce/">markmail.org</a><br />
+              <a class="externalLink" href="https://old.nabble.com/Apache-News-and-Announce-f109.html">old.nabble.com</a><br />
+              <a class="externalLink" href="https://www.mail-archive.com/announce@apache.org/">www.mail-archive.com</a><br />
+              <a class="externalLink" href="https://news.gmane.org/gmane.comp.apache.announce">news.gmane.org</a>
           </td>
         </tr>
       </table>


[commons-codec] 02/03: Remove unnecessary type casts.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git

commit fe39ffc076712fc8cd55c96fc5cb0eee2efe4847
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jul 20 10:57:12 2019 -0400

    Remove unnecessary type casts.
---
 src/main/java/org/apache/commons/codec/digest/MurmurHash2.java | 2 +-
 src/main/java/org/apache/commons/codec/digest/MurmurHash3.java | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/codec/digest/MurmurHash2.java b/src/main/java/org/apache/commons/codec/digest/MurmurHash2.java
index 45c8b61..c585d39 100644
--- a/src/main/java/org/apache/commons/codec/digest/MurmurHash2.java
+++ b/src/main/java/org/apache/commons/codec/digest/MurmurHash2.java
@@ -166,7 +166,7 @@ public final class MurmurHash2 {
 		case 2:
 			h ^= (long) (data[(length & ~7) + 1] & 0xff) << 8;
 		case 1:
-			h ^= (long) (data[length & ~7] & 0xff);
+			h ^= data[length & ~7] & 0xff;
 			h *= m;
 		}
 
diff --git a/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java b/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java
index 7c543ad..df46433 100644
--- a/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java
+++ b/src/main/java/org/apache/commons/codec/digest/MurmurHash3.java
@@ -461,7 +461,7 @@ public final class MurmurHash3 {
 		case 10:
 			k2 ^= (long) (data[offset + tailStart + 9] & 0xff) << 8;
 		case 9:
-			k2 ^= (long) (data[offset + tailStart + 8] & 0xff);
+			k2 ^= data[offset + tailStart + 8] & 0xff;
 			k2 *= C2;
 			k2 = Long.rotateLeft(k2, R3);
 			k2 *= C1;
@@ -482,7 +482,7 @@ public final class MurmurHash3 {
 		case 2:
 			k1 ^= (long) (data[offset + tailStart + 1] & 0xff) << 8;
 		case 1:
-			k1 ^= (long) (data[offset + tailStart] & 0xff);
+			k1 ^= data[offset + tailStart] & 0xff;
 			k1 *= C1;
 			k1 = Long.rotateLeft(k1, R1);
 			k1 *= C2;