You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Astro-Han (via GitHub)" <gi...@apache.org> on 2026/10/19 03:12:38 UTC
[PR] fix(release): keep plugin example tests out of source archives [maka]
Astro-Han opened a new pull request, #6159:
URL: https://github.com/apache/maka/pull/6159
## Summary
The 0.2.2 source-candidate workflow fails during extracted-source tests because the memory-network suite packages the Feishu example from `scripts/plugins`, which is deliberately excluded from ASF source archives. Normal checkout CI passes because that example is present.
Move that integration test unchanged into its own test file and exclude it alongside its repository-only dependency. The existing assistant runner still discovers and runs it in checkout CI. Keep the other external-source memory tests in the archive, and extend the existing archive regression to verify both sides of this boundary. Product behavior and release contents outside this test split are unchanged.
Refs #6148. Failed qualification: https://github.com/apache/maka/actions/runs/39192269771
## Verification
- Both checkout test files: 7 tests passed, including the real packaged Feishu integration.
- Actual candidate created from this commit and extracted: the retained source test file passed all 6 tests with `scripts/plugins` and its integration test absent. This focused local check reused installed dependencies; the full clean-install qualification remains with the source-candidate workflow after merge.
- Source-release suite: 23 tests passed. The new archive-boundary assertion failed before the export rule and passed after it.
- `npm run format`, `npm run lint`, and `git diff --check` passed.
- No product code changed; full local builds, typecheck, and E2E were not rerun.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex diagnosed the qualification failure, split the test, updated archive coverage, and ran the focused checks.
## Checklist
- [x] Tests cover the change and fail without it
- [ ] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [ ] Yes — described under Summary above
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(release): keep plugin example tests out of source archives [maka]
Posted by "Sun-GLiang (via GitHub)" <gi...@apache.org>.
Sun-GLiang commented on code in PR #6159:
URL: https://github.com/apache/maka/pull/6159#discussion_r4310035848
##########
.gitattributes:
##########
@@ -18,6 +18,8 @@
# Repository-only plugin examples are tested from a Git checkout, but are not
# ASF source-release inputs.
/scripts/plugins export-ignore
+# This integration test packages the repository-only Feishu plugin example.
+/packages/runtime-host/test/assistant/memory-network/test/feishu-source.test.ts export-ignore
Review Comment:
[P2] Also handle the remaining Feishu-dependent assistant test
This exclusion leaves `packages/runtime-host/test/assistant/proactive-matters/test/source-assistant-loop.test.ts` in the source archive, although lines 24–26 import `scripts/plugins/feishu-source/src/{message-cache,message-sync,sync-schedule}.js`. I checked `git archive` at this commit: that test is present and all three corresponding source modules are absent. `packages/runtime-host/scripts/test-assistant.mjs` discovers every `.test.ts` in `proactive-matters`, and the source-candidate workflow runs `npm test`, so qualification will still fail with a missing-module error once it reaches that suite. Please exclude or refactor this repository-only integration test as well and extend the archive regression to cover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(release): keep plugin example tests out of source archives [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #6159:
URL: https://github.com/apache/maka/pull/6159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org