You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/10/09 12:14:18 UTC
Review Request 62834: Applied checkpointing to dynamic agent total
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62834/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jan Schlicht.
Bugs: MESOS-8058
https://issues.apache.org/jira/browse/MESOS-8058
Repository: mesos
Description
-------
Previously agents only had static total resources stored as part of
their 'SlaveInfo'. Any operations were always applied to these
resources. We have since changed 'UpdateSlaveMessage' to be able to
communicate changes to agent total resources, and now trigger such an
update on e.g., agent registration. While the transmitted information
was redundant for now, this still introduced a race between agents
informing the master about their resources with an
'UpdateSlaveMessage' and the master attempting to update agents with
'CheckpointResourcesMessage'.
This patch applies checkpointed resources to the potentially dynamic
agent total resources instead of its static resources. This allows us
to catch inconsistencies between the master's view of the agent and
the agent's actual state in the agent and potentially trigger a
reconciliation.
Diffs
-----
src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
Diff: https://reviews.apache.org/r/62834/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 62834: Applied checkpointing to dynamic agent total
resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62834/#review187421
-----------------------------------------------------------
PASS: Mesos patch 62834 was successfully built and tested.
Reviews applied: `['62843', '62834']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62834
- Mesos Reviewbot Windows
On Oct. 9, 2017, 12:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62834/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2017, 12:14 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously agents only had static total resources stored as part of
> their 'SlaveInfo'. Any operations were always applied to these
> resources. We have since changed 'UpdateSlaveMessage' to be able to
> communicate changes to agent total resources, and now trigger such an
> update on e.g., agent registration. While the transmitted information
> was redundant for now, this still introduced a race between agents
> informing the master about their resources with an
> 'UpdateSlaveMessage' and the master attempting to update agents with
> 'CheckpointResourcesMessage'.
>
> This patch applies checkpointed resources to the potentially dynamic
> agent total resources instead of its static resources. This allows us
> to catch inconsistencies between the master's view of the agent and
> the agent's actual state in the agent and potentially trigger a
> reconciliation.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
>
>
> Diff: https://reviews.apache.org/r/62834/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62834: Applied checkpointing to dynamic agent total
resources.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62834/#review187411
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62843, 62834]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 9, 2017, 12:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62834/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2017, 12:14 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-8058
> https://issues.apache.org/jira/browse/MESOS-8058
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously agents only had static total resources stored as part of
> their 'SlaveInfo'. Any operations were always applied to these
> resources. We have since changed 'UpdateSlaveMessage' to be able to
> communicate changes to agent total resources, and now trigger such an
> update on e.g., agent registration. While the transmitted information
> was redundant for now, this still introduced a race between agents
> informing the master about their resources with an
> 'UpdateSlaveMessage' and the master attempting to update agents with
> 'CheckpointResourcesMessage'.
>
> This patch applies checkpointed resources to the potentially dynamic
> agent total resources instead of its static resources. This allows us
> to catch inconsistencies between the master's view of the agent and
> the agent's actual state in the agent and potentially trigger a
> reconciliation.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 2e05637ed10a39eb3f4ce953506b1cb5d50caf3c
>
>
> Diff: https://reviews.apache.org/r/62834/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>