[GitHub] williaster commented on a change in pull request #5031: Dashboard initial page load logging with tabs

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #5031: Dashboard initial page load logging with tabs
URL: https://github.com/apache/incubator-superset/pull/5031#discussion_r189677298
 
 

 ##########
 File path: superset/assets/src/dashboard/util/layoutHelper.js
 ##########
 @@ -0,0 +1,42 @@
+import {
 
 Review comment:
   can you separate this into one function per file? "util files" can easily become unreadable and way too long. I'd prefer more files over large ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org