You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rich Bowen <rb...@rcbowen.com> on 2010/11/04 17:26:05 UTC
Patch for mod_ssl
I'd like to make the following change to mod_ssl in 2.2. It's actually
a documentation change, in the sense that it changes an error message,
but I wanted to be sure that there's no strong objection to the change
before I make it. This attempts to avoid the confusion that happens
when you get an error message that doesn't actually tell you anything
useful.
Note: I've also made this change in trunk.
Index: ssl_engine_init.c
===================================================================
--- ssl_engine_init.c (revision 1029506)
+++ ssl_engine_init.c (working copy)
@@ -403,7 +403,7 @@
{
ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
"Illegal attempt to re-initialise SSL for server "
- "(theoretically shouldn't happen!)");
+ "(SSLEngine On should go in the VirtualHost, not in
global scope.)");
ssl_die();
}
}
--
Rich Bowen
rbowen@rcbowen.com
Re: Patch for mod_ssl
Posted by Graham Leggett <mi...@sharp.fm>.
On 04 Nov 2010, at 6:26 PM, Rich Bowen wrote:
> I'd like to make the following change to mod_ssl in 2.2. It's
> actually a documentation change, in the sense that it changes an
> error message, but I wanted to be sure that there's no strong
> objection to the change before I make it. This attempts to avoid the
> confusion that happens when you get an error message that doesn't
> actually tell you anything useful.
>
> Note: I've also made this change in trunk.
+1.
Regards,
Graham
--
Re: Patch for mod_ssl
Posted by Sander Temme <sc...@apache.org>.
On Nov 4, 2010, at 12:26 PM, Rich Bowen wrote:
> I'd like to make the following change to mod_ssl in 2.2. It's actually a documentation change, in the sense that it changes an error message, but I wanted to be sure that there's no strong objection to the change before I make it. This attempts to avoid the confusion that happens when you get an error message that doesn't actually tell you anything useful.
+1
> Note: I've also made this change in trunk.
>
> Index: ssl_engine_init.c
> ===================================================================
> --- ssl_engine_init.c (revision 1029506)
> +++ ssl_engine_init.c (working copy)
> @@ -403,7 +403,7 @@
> {
> ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
> "Illegal attempt to re-initialise SSL for server "
> - "(theoretically shouldn't happen!)");
> + "(SSLEngine On should go in the VirtualHost, not in global scope.)");
> ssl_die();
> }
> }
>
>
>
> --
> Rich Bowen
> rbowen@rcbowen.com
>
>
--
Sander Temme
sctemme@apache.org
PGP FP: FC5A 6FC6 2E25 2DFD 8007 EE23 9BB8 63B0 F51B B88A
View my availability: http://tungle.me/sctemme
Re: Patch for mod_ssl
Posted by Rich Bowen <rb...@rcbowen.com>.
Thanks.
I've applied the patch, based on the approval received so far.
I like error messages that are informative and tell you how to fix the
problem.
On Nov 4, 2010, at 2:32 PM, Jim Jagielski wrote:
> +1
>
> On Nov 4, 2010, at 12:26 PM, Rich Bowen wrote:
>
>> I'd like to make the following change to mod_ssl in 2.2. It's
>> actually a documentation change, in the sense that it changes an
>> error message, but I wanted to be sure that there's no strong
>> objection to the change before I make it. This attempts to avoid
>> the confusion that happens when you get an error message that
>> doesn't actually tell you anything useful.
>>
>> Note: I've also made this change in trunk.
>>
>> Index: ssl_engine_init.c
>> ===================================================================
>> --- ssl_engine_init.c (revision 1029506)
>> +++ ssl_engine_init.c (working copy)
>> @@ -403,7 +403,7 @@
>> {
>> ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
>> "Illegal attempt to re-initialise SSL for server "
>> - "(theoretically shouldn't happen!)");
>> + "(SSLEngine On should go in the VirtualHost, not
>> in global scope.)");
>> ssl_die();
>> }
>> }
>>
>>
>>
>> --
>> Rich Bowen
>> rbowen@rcbowen.com
>>
>
--
Rich Bowen
rbowen@rcbowen.com
Re: Patch for mod_ssl
Posted by Jim Jagielski <ji...@jaguNET.com>.
+1
On Nov 4, 2010, at 12:26 PM, Rich Bowen wrote:
> I'd like to make the following change to mod_ssl in 2.2. It's actually a documentation change, in the sense that it changes an error message, but I wanted to be sure that there's no strong objection to the change before I make it. This attempts to avoid the confusion that happens when you get an error message that doesn't actually tell you anything useful.
>
> Note: I've also made this change in trunk.
>
> Index: ssl_engine_init.c
> ===================================================================
> --- ssl_engine_init.c (revision 1029506)
> +++ ssl_engine_init.c (working copy)
> @@ -403,7 +403,7 @@
> {
> ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
> "Illegal attempt to re-initialise SSL for server "
> - "(theoretically shouldn't happen!)");
> + "(SSLEngine On should go in the VirtualHost, not in global scope.)");
> ssl_die();
> }
> }
>
>
>
> --
> Rich Bowen
> rbowen@rcbowen.com
>
Re: Patch for mod_ssl
Posted by Igor Galić <i....@brainsware.org>.
----- "Rich Bowen" <rb...@rcbowen.com> wrote:
> I'd like to make the following change to mod_ssl in 2.2. It's actually
> a documentation change, in the sense that it changes an error message,
> but I wanted to be sure that there's no strong objection to the change
> before I make it. This attempts to avoid the confusion that happens
> when you get an error message that doesn't actually tell you anything
> useful.
>
> Note: I've also made this change in trunk.
+1
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/