You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Philippus (via GitHub)" <gi...@apache.org> on 2023/02/26 16:34:35 UTC
[GitHub] [incubator-pekko-http] Philippus opened a new pull request, #87: Update naming for status codes 413 and 422
Philippus opened a new pull request, #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87
I think the naming changed in RFC 9110, see https://www.rfc-editor.org/rfc/rfc9110.html#name-413-content-too-large and https://www.rfc-editor.org/rfc/rfc9110.html#name-422-unprocessable-content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on pull request #87: Update naming for status codes 413 and 422
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1445408831
Are there any tests maintained for the legacy status codes? We need to prove that users can still respond with old status code variant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] Philippus commented on pull request #87: Update naming for status codes 413 and 422
Posted by "Philippus (via GitHub)" <gi...@apache.org>.
Philippus commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1651210636
I'll fix it up once the first pekko-http is out of the door.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1291060144
##########
http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/StatusCode.scala:
##########
@@ -151,8 +151,10 @@ object StatusCodes extends ObjectRegistry[Int, StatusCode] {
val Gone = reg(c(410)("Gone", "The resource requested is no longer available and will not be available again."))
val LengthRequired = reg(c(411)("Length Required", "The request did not specify the length of its content, which is required by the requested resource."))
val PreconditionFailed = reg(c(412)("Precondition Failed", "The server does not meet one of the preconditions that the requester put on the request."))
+ val ContentTooLarge = reg(c(413)("Content Too Large", "The request content is larger than the server is willing or able to process."))
+ @deprecated("deprecated in favor of ContentTooLarge", "1.0.0")
val PayloadTooLarge = reg(c(413)("Payload Too Large", "The request payload is larger than the server is willing or able to process."))
Review Comment:
```suggestion
val PayloadTooLarge = ContentTooLarge
```
##########
http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/StatusCode.scala:
##########
@@ -151,8 +151,10 @@ object StatusCodes extends ObjectRegistry[Int, StatusCode] {
val Gone = reg(c(410)("Gone", "The resource requested is no longer available and will not be available again."))
val LengthRequired = reg(c(411)("Length Required", "The request did not specify the length of its content, which is required by the requested resource."))
val PreconditionFailed = reg(c(412)("Precondition Failed", "The server does not meet one of the preconditions that the requester put on the request."))
+ val ContentTooLarge = reg(c(413)("Content Too Large", "The request content is larger than the server is willing or able to process."))
+ @deprecated("deprecated in favor of ContentTooLarge", "1.0.0")
val PayloadTooLarge = reg(c(413)("Payload Too Large", "The request payload is larger than the server is willing or able to process."))
- @deprecated("deprecated in favor of PayloadTooLarge", "Akka HTTP 10.1.11")
+ @deprecated("deprecated in favor of PayloadTooLarge, which was later deprecated in favor of ContentTooLarge (please switch to ContentTooLarge)", "Akka HTTP 10.1.11")
val RequestEntityTooLarge = PayloadTooLarge
Review Comment:
```suggestion
val RequestEntityTooLarge = ContentTooLarge
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #87: Update naming for status codes 413 and 422
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1674387750
> Are there any tests maintained for the legacy status codes? We need to prove that users can still respond with old status code variant.
This is only an API change and for those changes we mostly rely on Mima to catch problems. We also have the (currently disabled) "http-compatibility-tests" module which has logic to test backward compatibility in cases which warrant more testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #87: Update naming for status codes 413 and 422
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1448583849
> Is that something we would consider for 1.0.0? There's little risk but currently I'd say let's postpone to 1.1.x on principle since it is not strictly necessary right now?
Agreed, milestone set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on pull request #87: Update naming for status codes 413 and 422
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1564401788
there is no hurry on this as we are unlikely to include this in the pekko-http 1.0.0 release (and add it later instead)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1289215952
##########
http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/StatusCode.scala:
##########
@@ -151,8 +151,10 @@ object StatusCodes extends ObjectRegistry[Int, StatusCode] {
val Gone = reg(c(410)("Gone", "The resource requested is no longer available and will not be available again."))
val LengthRequired = reg(c(411)("Length Required", "The request did not specify the length of its content, which is required by the requested resource."))
val PreconditionFailed = reg(c(412)("Precondition Failed", "The server does not meet one of the preconditions that the requester put on the request."))
+ val ContentTooLarge = reg(c(413)("Content Too Large", "The request content is larger than the server is willing or able to process."))
+ @deprecated("deprecated in favor of ContentTooLarge", "1.0.0")
val PayloadTooLarge = reg(c(413)("Payload Too Large", "The request payload is larger than the server is willing or able to process."))
- @deprecated("deprecated in favor of PayloadTooLarge", "Akka HTTP 10.1.11")
+ @deprecated("deprecated in favor of ContentTooLarge", "1.0.0")
val RequestEntityTooLarge = PayloadTooLarge
Review Comment:
can you change this to this
```
@deprecated("deprecated in favor of PayloadTooLarge, which was later deprecated in favor of ContentTooLarge (please switch to ContentTooLarge)", "Akka HTTP 10.1.11")
```
* can you a comment - `// RequestEntityTooLarge was originally deprecated in favour of PayloadTooLarge in Akka HTTP 10.1.11` ?
* This will remind us that this line can actually be removed soon - possibly in Pekko 1.1.0 - because this line was already deprecated - but it does make sense to adjust the deprecation message now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #87: Update naming for status codes 413 and 422
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1564399145
@Philippus Apologies but my javafmt commit caused some merge conflicts on this PR but they are relatively minor. If you do a rebase on `origin/main` and run `sbt javafmt` it should remove the conflicts.
Let me know if you have time/are able to do this, otherwise I can just fix it up before merging the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1291063589
##########
http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/StatusCode.scala:
##########
@@ -165,6 +167,8 @@ object StatusCodes extends ObjectRegistry[Int, StatusCode] {
val ImATeapot = reg(c(418)("I'm a teapot", "The resulting entity body MAY be short and stout."))
val EnhanceYourCalm = reg(c(420)("Enhance Your Calm", "You are being rate-limited.")) // Twitter only
val MisdirectedRequest = reg(c(421)("Misdirected Request", "The request was directed at a server that is not able to produce a response.")) // HTTP/2 only. https://tools.ietf.org/html/rfc7540#section-9.1.2
+ val UnprocessableContent = reg(c(422)("Unprocessable Content", "The request was well-formed but was unable to be followed due to semantic errors."))
+ @deprecated("deprecated in favor of UnprocessableContent", "1.0.0")
val UnprocessableEntity = reg(c(422)("Unprocessable Entity", "The request was well-formed but was unable to be followed due to semantic errors."))
Review Comment:
Same here:
```suggestion
val UnprocessableEntity = UnprocessableContent
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1291144873
##########
http-core/src/main/java/org/apache/pekko/http/javadsl/model/StatusCodes.java:
##########
@@ -97,10 +97,19 @@ private StatusCodes() {}
org.apache.pekko.http.scaladsl.model.StatusCodes.LengthRequired();
public static final StatusCode PRECONDITION_FAILED =
org.apache.pekko.http.scaladsl.model.StatusCodes.PreconditionFailed();
+
+ public static final StatusCode CONTENT_TOO_LARGE =
+ org.apache.pekko.http.scaladsl.model.StatusCodes.ContentTooLarge();
+
+ /** @deprecated deprecated in favor of CONTENT_TOO_LARGE since 1.0.0 */
Review Comment:
:+1: good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #87: Update naming for status codes 413 and 422
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1674491421
(btw. test error is likely unrelated)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1291068134
##########
http-core/src/main/java/org/apache/pekko/http/javadsl/model/StatusCodes.java:
##########
@@ -97,10 +97,19 @@ private StatusCodes() {}
org.apache.pekko.http.scaladsl.model.StatusCodes.LengthRequired();
public static final StatusCode PRECONDITION_FAILED =
org.apache.pekko.http.scaladsl.model.StatusCodes.PreconditionFailed();
+
+ public static final StatusCode CONTENT_TOO_LARGE =
+ org.apache.pekko.http.scaladsl.model.StatusCodes.ContentTooLarge();
+
+ /** @deprecated deprecated in favor of CONTENT_TOO_LARGE since 1.0.0 */
Review Comment:
this should be `since 1.1.0` - 1.0.0 was released without this change
##########
http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/StatusCode.scala:
##########
@@ -151,9 +151,11 @@ object StatusCodes extends ObjectRegistry[Int, StatusCode] {
val Gone = reg(c(410)("Gone", "The resource requested is no longer available and will not be available again."))
val LengthRequired = reg(c(411)("Length Required", "The request did not specify the length of its content, which is required by the requested resource."))
val PreconditionFailed = reg(c(412)("Precondition Failed", "The server does not meet one of the preconditions that the requester put on the request."))
- val PayloadTooLarge = reg(c(413)("Payload Too Large", "The request payload is larger than the server is willing or able to process."))
- @deprecated("deprecated in favor of PayloadTooLarge", "Akka HTTP 10.1.11")
- val RequestEntityTooLarge = PayloadTooLarge
+ val ContentTooLarge = reg(c(413)("Content Too Large", "The request content is larger than the server is willing or able to process."))
+ @deprecated("deprecated in favor of ContentTooLarge", "1.0.0")
Review Comment:
this should be `"1.1.0"` - 1.0.0 was released without this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1291070043
##########
http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/StatusCode.scala:
##########
@@ -151,9 +151,11 @@ object StatusCodes extends ObjectRegistry[Int, StatusCode] {
val Gone = reg(c(410)("Gone", "The resource requested is no longer available and will not be available again."))
val LengthRequired = reg(c(411)("Length Required", "The request did not specify the length of its content, which is required by the requested resource."))
val PreconditionFailed = reg(c(412)("Precondition Failed", "The server does not meet one of the preconditions that the requester put on the request."))
- val PayloadTooLarge = reg(c(413)("Payload Too Large", "The request payload is larger than the server is willing or able to process."))
- @deprecated("deprecated in favor of PayloadTooLarge", "Akka HTTP 10.1.11")
- val RequestEntityTooLarge = PayloadTooLarge
+ val ContentTooLarge = reg(c(413)("Content Too Large", "The request content is larger than the server is willing or able to process."))
+ @deprecated("deprecated in favor of ContentTooLarge", "1.0.0")
Review Comment:
all the refs in this PR to deprecations since `1.0.0` should be changed to `1.1.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph merged pull request #87: Update naming for status codes 413 and 422
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph merged PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] He-Pin commented on pull request #87: Update naming for status codes 413 and 422
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1670588174
@Philippus You need rebase your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #87: Update naming for status codes 413 and 422
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1564407698
Indeed take your time, its not urgent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] Philippus commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "Philippus (via GitHub)" <gi...@apache.org>.
Philippus commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1118403841
##########
http-core/src/main/java/org/apache/pekko/http/javadsl/model/StatusCodes.java:
##########
@@ -66,10 +66,16 @@ private StatusCodes() {}
public static final StatusCode GONE = org.apache.pekko.http.scaladsl.model.StatusCodes.Gone();
public static final StatusCode LENGTH_REQUIRED = org.apache.pekko.http.scaladsl.model.StatusCodes.LengthRequired();
public static final StatusCode PRECONDITION_FAILED = org.apache.pekko.http.scaladsl.model.StatusCodes.PreconditionFailed();
+ public static final StatusCode CONTENT_TOO_LARGE = org.apache.pekko.http.scaladsl.model.StatusCodes.ContentTooLarge();
+
+ /**
+ * @deprecated deprecated in favor of CONTENT_TOO_LARGE
Review Comment:
not sure how to do this in the java comment. just add " since 1.0.0" to the comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #87: Update naming for status codes 413 and 422
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1446397317
Nice addition, thanks @Philippus.
Is that something we would consider for 1.0.0? There's little risk but currently I'd say let's postpone to 1.1.x on principle since it is not strictly necessary right now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1289215952
##########
http-core/src/main/scala/org/apache/pekko/http/scaladsl/model/StatusCode.scala:
##########
@@ -151,8 +151,10 @@ object StatusCodes extends ObjectRegistry[Int, StatusCode] {
val Gone = reg(c(410)("Gone", "The resource requested is no longer available and will not be available again."))
val LengthRequired = reg(c(411)("Length Required", "The request did not specify the length of its content, which is required by the requested resource."))
val PreconditionFailed = reg(c(412)("Precondition Failed", "The server does not meet one of the preconditions that the requester put on the request."))
+ val ContentTooLarge = reg(c(413)("Content Too Large", "The request content is larger than the server is willing or able to process."))
+ @deprecated("deprecated in favor of ContentTooLarge", "1.0.0")
val PayloadTooLarge = reg(c(413)("Payload Too Large", "The request payload is larger than the server is willing or able to process."))
- @deprecated("deprecated in favor of PayloadTooLarge", "Akka HTTP 10.1.11")
+ @deprecated("deprecated in favor of ContentTooLarge", "1.0.0")
val RequestEntityTooLarge = PayloadTooLarge
Review Comment:
can you change this to this?
```
@deprecated("deprecated in favor of PayloadTooLarge, which was later deprecated in favor of ContentTooLarge (please switch to ContentTooLarge)", "Akka HTTP 10.1.11")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #87: Update naming for status codes 413 and 422
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1674617753
Thanks again, @Philippus!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1118119683
##########
http-core/src/main/java/org/apache/pekko/http/javadsl/model/StatusCodes.java:
##########
@@ -66,10 +66,16 @@ private StatusCodes() {}
public static final StatusCode GONE = org.apache.pekko.http.scaladsl.model.StatusCodes.Gone();
public static final StatusCode LENGTH_REQUIRED = org.apache.pekko.http.scaladsl.model.StatusCodes.LengthRequired();
public static final StatusCode PRECONDITION_FAILED = org.apache.pekko.http.scaladsl.model.StatusCodes.PreconditionFailed();
+ public static final StatusCode CONTENT_TOO_LARGE = org.apache.pekko.http.scaladsl.model.StatusCodes.ContentTooLarge();
+
+ /**
+ * @deprecated deprecated in favor of CONTENT_TOO_LARGE
Review Comment:
Could you include `since = "1.0.0"` on all new deprecations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1118502568
##########
http-core/src/main/java/org/apache/pekko/http/javadsl/model/StatusCodes.java:
##########
@@ -66,10 +66,16 @@ private StatusCodes() {}
public static final StatusCode GONE = org.apache.pekko.http.scaladsl.model.StatusCodes.Gone();
public static final StatusCode LENGTH_REQUIRED = org.apache.pekko.http.scaladsl.model.StatusCodes.LengthRequired();
public static final StatusCode PRECONDITION_FAILED = org.apache.pekko.http.scaladsl.model.StatusCodes.PreconditionFailed();
+ public static final StatusCode CONTENT_TOO_LARGE = org.apache.pekko.http.scaladsl.model.StatusCodes.ContentTooLarge();
+
+ /**
+ * @deprecated deprecated in favor of CONTENT_TOO_LARGE
Review Comment:
https://www.scala-lang.org/api/2.13.10/scala/deprecated.html describes how to set the 'since value' in Scala deprecations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1118500028
##########
http-core/src/main/java/org/apache/pekko/http/javadsl/model/StatusCodes.java:
##########
@@ -66,10 +66,16 @@ private StatusCodes() {}
public static final StatusCode GONE = org.apache.pekko.http.scaladsl.model.StatusCodes.Gone();
public static final StatusCode LENGTH_REQUIRED = org.apache.pekko.http.scaladsl.model.StatusCodes.LengthRequired();
public static final StatusCode PRECONDITION_FAILED = org.apache.pekko.http.scaladsl.model.StatusCodes.PreconditionFailed();
+ public static final StatusCode CONTENT_TOO_LARGE = org.apache.pekko.http.scaladsl.model.StatusCodes.ContentTooLarge();
+
+ /**
+ * @deprecated deprecated in favor of CONTENT_TOO_LARGE
Review Comment:
probably best to read https://www.baeldung.com/javadoc-version-since
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #87: Update naming for status codes 413 and 422
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#discussion_r1118119683
##########
http-core/src/main/java/org/apache/pekko/http/javadsl/model/StatusCodes.java:
##########
@@ -66,10 +66,16 @@ private StatusCodes() {}
public static final StatusCode GONE = org.apache.pekko.http.scaladsl.model.StatusCodes.Gone();
public static final StatusCode LENGTH_REQUIRED = org.apache.pekko.http.scaladsl.model.StatusCodes.LengthRequired();
public static final StatusCode PRECONDITION_FAILED = org.apache.pekko.http.scaladsl.model.StatusCodes.PreconditionFailed();
+ public static final StatusCode CONTENT_TOO_LARGE = org.apache.pekko.http.scaladsl.model.StatusCodes.ContentTooLarge();
+
+ /**
+ * @deprecated deprecated in favor of CONTENT_TOO_LARGE
Review Comment:
Could you include `@since = "1.0.0"` on all new deprecations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #87: Update naming for status codes 413 and 422
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #87:
URL: https://github.com/apache/incubator-pekko-http/pull/87#issuecomment-1674384438
Was about to say that the tests are failing with `java.lang.NoClassDefFoundError: Could not initialize class org.apache.pekko.http.scaladsl.model.StatusCodes$`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org