You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/24 09:04:13 UTC
[GitHub] [pulsar] eolivelli opened a new issue #13490: PIP-124: Pulsar Client Shared State API (draft)
eolivelli opened a new issue #13490:
URL: https://github.com/apache/pulsar/issues/13490
<!---
Instructions for creating a PIP using this issue template:
1. The author(s) of the proposal will create a GitHub issue ticket using this template.
(Optionally, it can be helpful to send a note discussing the proposal to
dev@pulsar.apache.org mailing list before submitting this GitHub issue. This discussion can
help developers gauge interest in the proposed changes before formalizing the proposal.)
2. The author(s) will send a note to the dev@pulsar.apache.org mailing list
to start the discussion, using subject prefix `[PIP] xxx`. To determine the appropriate PIP
number `xxx`, inspect the mailing list (https://lists.apache.org/list.html?dev@pulsar.apache.org)
for the most recent PIP. Add 1 to that PIP's number to get your PIP's number.
3. Based on the discussion and feedback, some changes might be applied by
the author(s) to the text of the proposal.
4. Once some consensus is reached, there will be a vote to formally approve
the proposal. The vote will be held on the dev@pulsar.apache.org mailing list. Everyone
is welcome to vote on the proposal, though it will considered to be binding
only the vote of PMC members. It will be required to have a lazy majority of
at least 3 binding +1s votes. The vote should stay open for at least 48 hours.
5. When the vote is closed, if the outcome is positive, the state of the
proposal is updated and the Pull Requests associated with this proposal can
start to get merged into the master branch.
-->
## Motivation
Explain why this change is needed, what benefits it would bring to Apache Pulsar
and what problem it's trying to solve.
## Goal
Define the scope of this proposal. Given the motivation stated above, what are
the problems that this proposal is addressing and what other items will be
considering out of scope, perhaps to be left to a different PIP.
## API Changes
Illustrate all the proposed changes to the API or wire protocol, with examples
of all the newly added classes/methods, including Javadoc.
## Implementation
This should be a detailed description of all the changes that are
expected to be made. It should be detailed enough that any developer that is
familiar with Pulsar internals would be able to understand all the parts of the
code changes for this proposal.
This should also serve as documentation for any person that is trying to
understand or debug the behavior of a certain feature.
## Reject Alternatives
If there are alternatives that were already considered by the authors or,
after the discussion, by the community, and were rejected, please list them
here along with the reason why they were rejected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on issue #13490: PIP-124: Pulsar Client Shared State API
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on issue #13490:
URL: https://github.com/apache/pulsar/issues/13490#issuecomment-1001198816
Could i help with this PIP ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on issue #13490: PIP-124: Pulsar Client Shared State API
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #13490:
URL: https://github.com/apache/pulsar/issues/13490#issuecomment-1018346098
@mattisonchao yes you could, but most of the code is already in the attached github repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #13490: PIP-137: Pulsar Client Shared State API
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #13490:
URL: https://github.com/apache/pulsar/issues/13490#issuecomment-1052935441
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao edited a comment on issue #13490: PIP-124: Pulsar Client Shared State API
Posted by GitBox <gi...@apache.org>.
mattisonchao edited a comment on issue #13490:
URL: https://github.com/apache/pulsar/issues/13490#issuecomment-1001198816
@eolivelli
Could i help with this PIP ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on issue #13490: PIP-124: Pulsar Client Shared State API
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #13490:
URL: https://github.com/apache/pulsar/issues/13490#issuecomment-1018354788
we talked in the Community meeting about this PIP.
The main concern from @merlimat is the exposing a "put" operation will give a false illusion that you have something like a Map, but actually every "write" operation will be "slow" because we need to acquire the Producer lock.
@merlimat suggested to split this into two distinct interfaces: a API for readers and one for writers, possibly extending the work done on PIP-104 TableViews (https://github.com/apache/pulsar/issues/12356).
I am fine with extending PIP-104 in that direction (to add a writer side of the TableView), but I believe that the API proposed here is going to give a API to achieve the goal of having a generic "Java object" as share state, by letting the developer of the Shared State Object deal with the internal representation.
Using the TableView API will forces users to represent their Java object as a set of properties or a single object with one fixed key. It is feasible, but not straightforward from my point of view.
I really would like to mimic Pravega.io StateSynchronizer support, that does not force you to see your topic as a "table".
@merlimat
I will work in parallel on extending the TableView API to add writer support, I am sure it will bring a big value to the users.
But I still thing that we should add this "Recipe" to the Pulsar Adapters repository
@merlimat WDTY ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao removed a comment on issue #13490: PIP-137: Pulsar Client Shared State API
Posted by GitBox <gi...@apache.org>.
mattisonchao removed a comment on issue #13490:
URL: https://github.com/apache/pulsar/issues/13490#issuecomment-1001198816
@eolivelli
Could i help with this PIP ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on issue #13490: PIP-124: Pulsar Client Shared State API
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on issue #13490:
URL: https://github.com/apache/pulsar/issues/13490#issuecomment-1001284861
This PIP number is duplicated with https://github.com/apache/pulsar/issues/13408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org