You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/07 12:12:22 UTC
[GitHub] [airflow] turbaszek opened a new pull request, #22813: Add SmoothOperator
turbaszek opened a new pull request, #22813:
URL: https://github.com/apache/airflow/pull/22813
Easter is coming so I just came with idea of an harmless easter egg 😄
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #22813:
URL: https://github.com/apache/airflow/pull/22813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22813:
URL: https://github.com/apache/airflow/pull/22813#issuecomment-1095435812
Not SADE any more and just random failure. Merging :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22813:
URL: https://github.com/apache/airflow/pull/22813#issuecomment-1095436388
Just in time for 2.3.0.
We could not wait for SmoothOperator. It's been highly requested feature by many.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #22813:
URL: https://github.com/apache/airflow/pull/22813#issuecomment-1091754337
This operator may be too criminal to use in production
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #22813:
URL: https://github.com/apache/airflow/pull/22813#issuecomment-1091755743
Yes the `inherits_from_dummy_operator` check would kick in to not run `execute`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22813:
URL: https://github.com/apache/airflow/pull/22813#issuecomment-1092880073
But even smooth operator needs some :heart: when it comes to static checks :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22813:
URL: https://github.com/apache/airflow/pull/22813#issuecomment-1091742569
Will it actually log any outpit :) ? I think not as Dummy Opertor's execute is not well.. executed :)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a diff in pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
turbaszek commented on code in PR #22813:
URL: https://github.com/apache/airflow/pull/22813#discussion_r846801836
##########
airflow/operators/smooth.py:
##########
@@ -0,0 +1,38 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from airflow.models.baseoperator import BaseOperator
+from airflow.utils.context import Context
+
+
+class SmoothOperator(BaseOperator):
+ """
+ Operator that does literally nothing but it logs YouTube link to
+ Sade song "Smooth Operator".
+
+ The task is evaluated by the scheduler but never processed by the executor.
+ """
+
+ ui_color = '#e8f7e4'
+ inherits_from_dummy_operator = False
Review Comment:
Good catch, fixed! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #22813:
URL: https://github.com/apache/airflow/pull/22813#discussion_r846244652
##########
airflow/operators/smooth.py:
##########
@@ -0,0 +1,38 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from airflow.models.baseoperator import BaseOperator
+from airflow.utils.context import Context
+
+
+class SmoothOperator(BaseOperator):
+ """
+ Operator that does literally nothing but it logs YouTube link to
+ Sade song "Smooth Operator".
+
+ The task is evaluated by the scheduler but never processed by the executor.
+ """
+
+ ui_color = '#e8f7e4'
+ inherits_from_dummy_operator = False
Review Comment:
Now that it's no longer inherit from `DummyOperator`
do we still need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #22813:
URL: https://github.com/apache/airflow/pull/22813#issuecomment-1094333749
Static checks are Sade, ehm SAD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #22813:
URL: https://github.com/apache/airflow/pull/22813#discussion_r846244652
##########
airflow/operators/smooth.py:
##########
@@ -0,0 +1,38 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from airflow.models.baseoperator import BaseOperator
+from airflow.utils.context import Context
+
+
+class SmoothOperator(BaseOperator):
+ """
+ Operator that does literally nothing but it logs YouTube link to
+ Sade song "Smooth Operator".
+
+ The task is evaluated by the scheduler but never processed by the executor.
+ """
+
+ ui_color = '#e8f7e4'
+ inherits_from_dummy_operator = False
Review Comment:
Now that it's no longer inherit from `DummyOperator`
do we still need `inherits_from_dummy_operator`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #22813:
URL: https://github.com/apache/airflow/pull/22813#discussion_r846246204
##########
airflow/operators/smooth.py:
##########
@@ -0,0 +1,38 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from airflow.models.baseoperator import BaseOperator
+from airflow.utils.context import Context
+
+
+class SmoothOperator(BaseOperator):
+ """
+ Operator that does literally nothing but it logs YouTube link to
+ Sade song "Smooth Operator".
+
+ The task is evaluated by the scheduler but never processed by the executor.
+ """
+
+ ui_color = '#e8f7e4'
+ inherits_from_dummy_operator = False
Review Comment:
No, this is automatically False
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22813: Add SmoothOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22813:
URL: https://github.com/apache/airflow/pull/22813#issuecomment-1091751679
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org