You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Remilito <gi...@git.apache.org> on 2017/03/27 16:40:32 UTC
[GitHub] zeppelin pull request #2194: [ZEPPELIN-2229] Providing workaround for nvd3 v...
GitHub user Remilito opened a pull request:
https://github.com/apache/zeppelin/pull/2194
[ZEPPELIN-2229] Providing workaround for nvd3 voronoi
### What is this PR for?
After bumping nvd3 to 1.8.5, an error was spotted due to a bug in nvd3. This PR provides a workaround until the proper nvd3 fix is released.
* create a jitter and deduplicate data
* adapt axis tick format to hide the jitter
* add y label for non-numeric value
* this code can be safely removed after nvd3 [#1934](https://github.com/novus/nvd3/pull/1934) is released ( >
1.8.5) and bumped in zeppelin project
### What type of PR is it?
Bug Fix
### Todos
* [ ] - When bumping nvd3 to a version > 1.8.5, remove the code marked with TODO
### What is the Jira issue?
[ZEPPELIN-2229](https://issues.apache.org/jira/browse/ZEPPELIN-2229)
### How should this be tested?
See [#2186](https://github.com/apache/zeppelin/pull/2186). Switch between any chart and scatter chart with a large number of rows.
### Screenshots (if appropriate)
See [#2186](https://github.com/apache/zeppelin/pull/2186).
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Remilito/zeppelin ZEPPELIN-2229
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2194.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2194
----
commit 017ab390a6a7a07055f6bd6209104d52a4144c74
Author: Remilito <re...@gmail.com>
Date: 2017-03-27T16:27:39Z
[ZEPPELIN-2229] Providing workaround for nvd3 voronoi
* create a jitter and deduplicate data
* adapt axis tick format to hide the jitter
* add y label for non-numeric value
* this code can be safely removed after nvd3 #1934 is released ( >
1.8.5) and bumped in zeppelin project
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2194: [ZEPPELIN-2229] Providing workaround for nvd3 voronoi
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/2194
Thank you for the contribution @Remilito. Merging it into master and branch-0.7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2194: [ZEPPELIN-2229] Providing workaround for nvd3 voronoi
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2194
I checked the similar issue ["TypeError: Cannot read property '1' of undefined" in the bar chart](https://issues.apache.org/jira/browse/ZEPPELIN-2273) we have.
This error is occured when changing radio button from `Grouped` to `Stacked` like the following screenshot.
But, Fortunately, there is no problem in this branch so, we can also resolve it with this PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2194: [ZEPPELIN-2229] Providing workaround for nvd3 voronoi
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2194
Tested it out and it works very well!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2194: [ZEPPELIN-2229] Providing workaround for nvd3 voronoi
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2194
@Remilito Sounds great! It looks good to me.
With this PR, we can keep on using the latest version of the nvd3. Personally, I like your annotations per code spot. Because it can keep remind us and it would be comfortable when bump up version.
Anyway, I'll check and test it out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2194: [ZEPPELIN-2229] Providing workaround for nvd3 v...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---