You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2023/07/18 14:22:45 UTC
Change in asterixdb[stabilization-667a908755]: [ASTERIXDB-3226][STO] Warn on missing primary index during flush
From Murtadha Al Hubail <mh...@apache.org>:
Murtadha Al Hubail has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17647 )
Change subject: [ASTERIXDB-3226][STO] Warn on missing primary index during flush
......................................................................
[ASTERIXDB-3226][STO] Warn on missing primary index during flush
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- To account for leaked secondary files, warn rather than halting
on missing primary index during flush to allow recovery to complete.
Eventually, the leaked files will be deleted during global recovery.
- Fix log message.
Change-Id: I7858a67cfc97fb1fde01c463a256083952d51543
---
M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
2 files changed, 24 insertions(+), 5 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/47/17647/1
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
index 9b722df..05bc87b 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
@@ -244,6 +244,6 @@
@Override
public String toString() {
return String.format("%s(id=%s, from=%s, uuid=%s): %s", getClass().getSimpleName(), requestMessageId,
- requestNodeId, LogRedactionUtil.statement(statementsText), requestReference.getUuid());
+ requestNodeId, requestReference.getUuid(), LogRedactionUtil.statement(statementsText));
}
}
diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
index b0d8e02..8491f6c 100644
--- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
+++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java
@@ -51,7 +51,6 @@
import org.apache.hyracks.storage.am.lsm.common.impls.LSMComponentId;
import org.apache.hyracks.storage.common.IModificationOperationCallback;
import org.apache.hyracks.storage.common.ISearchOperationCallback;
-import org.apache.hyracks.util.ExitUtil;
import org.apache.hyracks.util.annotations.NotThreadSafe;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -151,10 +150,10 @@
}
}
if (primaryLsmIndex == null) {
- LOGGER.fatal(
- "Primary index not found in dataset {} and partition {} open indexes {}; halting to clear memory state",
+ LOGGER.warn(
+ "Primary index not found in dataset {} and partition {} open indexes {}; possible secondary index leaked files",
dsInfo.getDatasetID(), partition, indexes);
- ExitUtil.halt(ExitUtil.EC_INCONSISTENT_STORAGE_REFERENCES);
+ return;
}
for (ILSMIndex lsmIndex : indexes) {
ILSMOperationTracker opTracker = lsmIndex.getOperationTracker();
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/17647
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-667a908755
Gerrit-Change-Id: I7858a67cfc97fb1fde01c463a256083952d51543
Gerrit-Change-Number: 17647
Gerrit-PatchSet: 1
Gerrit-Owner: Murtadha Al Hubail <mh...@apache.org>
Gerrit-MessageType: newchange