You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "vukasin-djuricic (via GitHub)" <gi...@apache.org> on 2026/08/06 00:24:20 UTC
[PR] Fix stale block size comments in Lucene104 postings reader/writer [lucene]
vukasin-djuricic opened a new pull request, #16491:
URL: https://github.com/apache/lucene/pull/16491
Fixes #15670.
BLOCK_SIZE went from 128 to 256 in 10.4, but a few comments still spell out
values computed with the old block size:
- Lucene104PostingsWriter: level 1 skip data is written every 32 blocks, which
is 8,192 docs, not 4,096.
- Lucene104PostingsWriter: BLOCK_SIZE * Integer.SIZE / Long.SIZE is 128, not 64.
The assert on the next line already uses BLOCK_SIZE / 2.
- Lucene104PostingsReader: BLOCK_SIZE / Long.SIZE is 4, not 2.
This is a follow-up to #15672, where the question was raised whether other
comments needed the same fix. These are the ones I could find. The version
history in package-info.java is correct as is, since it describes the 9.12
format where BLOCK_SIZE was still 128.
Documentation only, no change in behaviour, so no CHANGES.txt entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix stale block size comments in Lucene104 postings reader/writer [lucene]
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz merged PR #16491:
URL: https://github.com/apache/lucene/pull/16491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix stale block size comments in Lucene104 postings reader/writer [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #16491:
URL: https://github.com/apache/lucene/pull/16491#issuecomment-5376706861
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org