You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tinkoff-dwh <gi...@git.apache.org> on 2017/03/14 11:58:31 UTC
[GitHub] zeppelin pull request #2134: [ZEPPELIN-2257] notification about incompletene...
GitHub user tinkoff-dwh opened a pull request:
https://github.com/apache/zeppelin/pull/2134
[ZEPPELIN-2257] notification about incompleteness of data
### What is this PR for?
Added notification about exceeding the limit in the result.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2257
### How should this be tested?
1. Create table *test* with more than 2 records (if not exists)
2. Set parameter `common.max_count ` = 2
3. Execute
```
%jdbc
select *from test
```
You should see message about exceeds limit
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2257
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2134
----
commit 2cd3633f4523b2d1c7961de150b44a56d01d0c8d
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-14T10:55:02Z
[ZEPPELIN-2257] notification about incompleteness of data
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2134
Tested and basically agree with @Leemoonsoo. But one thing I just noticed is this new message can be seen in report mode.
I think it would be better we can hide this msg in this case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
Merge to master and branch-0.7 if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2134: [ZEPPELIN-2257] notification about incompletene...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
CI green https://travis-ci.org/tinkoff-dwh/zeppelin/builds/213063178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@Leemoonsoo
what final version, bootstrap?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2134: [ZEPPELIN-2257] notification about incompletene...
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2134
[ZEPPELIN-2257] notification about incompleteness of data
### What is this PR for?
Added notification about exceeding the limit in the result.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2257
### How should this be tested?
1. Create table *test* with more than 2 records (if not exists)
2. Set parameter `common.max_count ` = 2
3. Execute
```
%jdbc
select *from test
```
You should see message about exceeds limit
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2257
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2134
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by masyan <gi...@git.apache.org>.
Github user masyan commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@AhyoungRyu
if you configure the note and working only in report mode then you will not see when the report is incomplete.I can add the close button
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
#### Message location
Because of existing message `Results are limited by X.` and `Output exceeds 10240. Truncated.` are displayed below the table.
I think showing `Attention! Result is incomplete ...` below the table helps keep user experience more consistent.
#### Message style
Bootstrap decoration is pretty. If we apply bootstrap alert to all 3 messages, then that means existing 2 message ux is changed, too.
From taking less height of the screen, receiving less attention,
To taking more height of the screen, receiving more attention.
So which is the way we should go do you guys think? @tinkoff-dwh @1ambda
#### Message text
All three message are different.
`Results are limited by X.`
`Output exceeds 10240. Truncated.`
`Attention! Result is incomplete ...`
It'll be better use similar form of message. But how they're limited are all different. And it'll be great if we user give some link how they're limited.
So for example,
`Output is truncated to X rows. Learn more about common.max_count`
`Output is truncated to 10240 bytes. learn more about ZEPPELIN_INTERPRETER_OUTPUT_LIMIT`
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@Leemoonsoo
Yes you were right, this margin from alert (bootstreap class). fix it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2134: [ZEPPELIN-2257] notification about incompletene...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
travis does not work (build was not created for last commit)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2134: [ZEPPELIN-2257] notification about incompletene...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@tinkoff-dwh thanks!
It's nit, but bottom margin is bit much compare to other margins in paragraph. i tried mark other margins.
Of course there's no rule that all the margin should be the same, but the margin on bottom looks bit inconsistent. Message is already decorated by bootstrap box so it already gives good visual separation.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@tinkoff-dwh Thanks! Looks good :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2134
Sorry for late reply.
- regarding to design, it would be great if we use bootstrap-alert. (`warning` level would be ok)
For example,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
In addition to @prabhjyotsingh mentions, there are another type of message controlled by `ZEPPELIN_INTERPRETER_OUTPUT_LIMIT` env variable.
All three messages Color, location, Decorations are different.
Basically these three messages are saying the same thing "Not a complete data".
So it make sense to display all three message in similar way, i think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@tinkoff-dwh Then you can make this CI status green by reopening-closing this PR :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2134: [ZEPPELIN-2257] notification about incompletene...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@Leemoonsoo
possible. This margin within HTML Message maybe there are problems in other messages (without bootstrap). I'll try.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
LGTM and merge to master if no further discussions.
Thanks @tinkoff-dwh for the improvement!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
Just saw it, this definitely looks better. I don't have a strong opinion, I just saw there is a small diff, hence, highlighting it.
This is how it gets displayed in spark/livy, with some extra information.
<img width="1422" alt="screen shot 2017-03-16 at 10 21 36 pm" src="https://cloud.githubusercontent.com/assets/674497/24008365/70a6eaa0-0a97-11e7-901c-59cfe7ad7913.png">
And this is how it will look like if there were multiple queries.
<img width="1429" alt="screen shot 2017-03-16 at 10 24 54 pm" src="https://cloud.githubusercontent.com/assets/674497/24008366/70aa1360-0a97-11e7-965a-9f5acafe01fe.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
CI green https://travis-ci.org/tinkoff-dwh/zeppelin/builds/211619211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2134
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2134: [ZEPPELIN-2257] notification about incompletene...
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2134
[ZEPPELIN-2257] notification about incompleteness of data
### What is this PR for?
Added notification about exceeding the limit in the result.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2257
### How should this be tested?
1. Create table *test* with more than 2 records (if not exists)
2. Set parameter `common.max_count ` = 2
3. Execute
```
%jdbc
select *from test
```
You should see message about exceeds limit
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2257
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2134
----
commit edeca0e10910f004978e512888a46058723325c2
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-20T19:09:11Z
[ZEPPELIN-2257] notifications about incompleteness of data
commit d6dbe3e9fdcea5e0c4747e3a9a0bfa13438f209c
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-20T19:40:56Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2257
commit 2e6c97690bb288d039bfb0d04aea54bf63b23cf7
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-24T06:19:06Z
[ZEPPELIN-2257] close button to alert
commit 3c52b52811851d70472ba027067569b662b5969a
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-27T06:25:03Z
[ZEPPELIN-2257] custom css class for alert
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2134: [ZEPPELIN-2257] notification about incompletene...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by sotnich <gi...@git.apache.org>.
Github user sotnich commented on the issue:
https://github.com/apache/zeppelin/pull/2134
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@AhyoungRyu
if you configure the note and working only in report mode then you will not see when the report is incomplete.I can add the close button
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2134: [ZEPPELIN-2257] notification about incompletene...
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2134
[ZEPPELIN-2257] notification about incompleteness of data
### What is this PR for?
Added notification about exceeding the limit in the result.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2257
### How should this be tested?
1. Create table *test* with more than 2 records (if not exists)
2. Set parameter `common.max_count ` = 2
3. Execute
```
%jdbc
select *from test
```
You should see message about exceeds limit
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2257
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2134
----
commit edeca0e10910f004978e512888a46058723325c2
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-20T19:09:11Z
[ZEPPELIN-2257] notifications about incompleteness of data
commit d6dbe3e9fdcea5e0c4747e3a9a0bfa13438f209c
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-20T19:40:56Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2257
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@Leemoonsoo
I think now is fine (data table + message separated from footer), but I can increase the top margin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2134: [ZEPPELIN-2257] notification about incompletene...
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2134
[ZEPPELIN-2257] notification about incompleteness of data
### What is this PR for?
Added notification about exceeding the limit in the result.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2257
### How should this be tested?
1. Create table *test* with more than 2 records (if not exists)
2. Set parameter `common.max_count ` = 2
3. Execute
```
%jdbc
select *from test
```
You should see message about exceeds limit
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2257
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2134
----
commit 2cd3633f4523b2d1c7961de150b44a56d01d0c8d
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-14T10:55:02Z
[ZEPPELIN-2257] notification about incompleteness of data
commit e53cf945c9bc7e2626de524849af080ce5e31f82
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-16T04:42:19Z
[ZEPPELIN-2257] change alert
commit ac6075766ad7cb7bcf477cefb8b9b591a69baf61
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-16T04:55:41Z
[ZEPPELIN-2257] format message
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@Leemoonsoo
*location*
I think it's better to display above table because the output can be large and user will not see message.
*style*
Bootstreap attracts attention and this is important
*text*
Output is truncated to {count} rows. Learn more about {variable_name}
sorry for offtopic. @Leemoonsoo can you watch https://github.com/apache/zeppelin/pull/2085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
Top margin looks bit small and bottom margin looks too large. What do you think adjust them little bit and make top and bottom margin the same?
@1ambda @AhyoungRyu @prabhjyotsingh @felixcheung @zjffdu @jongyoul Can you guys take a look and give some feedback how this new message style looks like?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@tinkoff-dwh Ah, i see. i didn't see where this margin comes from.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2134
> I can add the close button
@tinkoff-dwh Yeah that's better. Having close button will be better for other cases as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---