[GitHub] [james-project] chibenwa commented on a diff in pull request #1070: [Cleanup] - Testcontainer - The docker image of test dependencies (cassandra, s3...) should be one immutable

[GitBox <gi...@apache.org>]

chibenwa commented on code in PR #1070:
URL: https://github.com/apache/james-project/pull/1070#discussion_r909527131


##########
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/DockerCassandra.java:
##########
@@ -164,7 +165,7 @@ public void close() throws IOException {
         });
         boolean doNotDeleteImageAfterUsage = false;
         cassandraContainer = new GenericContainer<>(
-            new ImageFromDockerfile(imageName,doNotDeleteImageAfterUsage)
+            new ImageFromDockerfile("james-testing-cassandra", doNotDeleteImageAfterUsage)

Review Comment:
   > I guess the idea here is to avoid creating duplicated images with different names. But if we utilize the SINGLETON properly, we already avoid this.
   
   Not across maven modules. Surefires forks runs on their own JVM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org