You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/05/12 09:53:13 UTC
[GitHub] [incubator-seatunnel] BenJFan opened a new pull request, #1863: [Api-draft] Support Spark Sink convert to SeaTunnel
BenJFan opened a new pull request, #1863:
URL: https://github.com/apache/incubator-seatunnel/pull/1863
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Support Spark Sink convert to SeaTunnel
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1863: [Api-draft] Support Spark Sink convert to SeaTunnel
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1863:
URL: https://github.com/apache/incubator-seatunnel/pull/1863#issuecomment-1125610797
> Why does the Converter interface exist? Each engine can directly convert the sink of seatunnel to it‘s inner class when translating, and the converter just makes the class file more.
I think Converter can make the convert logic clearer, let the engine translation implementers know what components they need to convert, and a more general code structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1863: [Api-draft] Support Spark Sink convert to SeaTunnel
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1863:
URL: https://github.com/apache/incubator-seatunnel/pull/1863#issuecomment-1125620889
> > > Why does the Converter interface exist? Each engine can directly convert the sink of seatunnel to it‘s inner class when translating, and the converter just makes the class file more.
> >
> >
> > I think Converter can make the convert logic clearer, let the engine translation implementers know what components they need to convert, and a more general code structure.
>
> @ruanwenjun @CalvinKirs What do you think?
If we can define a template method by converter, this will be great. Anyway, I think we need to implement this first, the code can be optimized if we find any problem. The current implementation is OK to me.
In my knowledge, we need to implement different translation for different version. For example, we may need to create a module `seatunnel-translation-flink1.11` to support flink 1.11, and create a module `seatunnel-translation-flink2.11` to support the version 2.11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #1863: [Api-draft] Support Spark Sink convert to SeaTunnel
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #1863:
URL: https://github.com/apache/incubator-seatunnel/pull/1863#issuecomment-1125612955
I think how to translate can only be determined by the current engine. For example, on flink 1.11, SinkCommitter and SinkWriter cannot be converted separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #1863: [Api-draft] Support Spark Sink convert to SeaTunnel
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #1863:
URL: https://github.com/apache/incubator-seatunnel/pull/1863#issuecomment-1125607218
Why does the Converter interface exist? Each engine can directly convert the sink of seatunnel to it‘s inner class when translating, and the converter just makes the class file more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1863: [Api-draft] Support Spark Sink convert to SeaTunnel
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1863:
URL: https://github.com/apache/incubator-seatunnel/pull/1863#issuecomment-1125627697
I merge this first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1863: [Api-draft] Support Spark Sink convert to SeaTunnel
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1863:
URL: https://github.com/apache/incubator-seatunnel/pull/1863#issuecomment-1125611297
> > Why does the Converter interface exist? Each engine can directly convert the sink of seatunnel to it‘s inner class when translating, and the converter just makes the class file more.
>
> I think Converter can make the convert logic clearer, let the engine translation implementers know what components they need to convert, and a more general code structure.
@ruanwenjun @CalvinKirs What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] BenJFan commented on pull request #1863: [Api-draft] Support Spark Sink convert to SeaTunnel
Posted by GitBox <gi...@apache.org>.
BenJFan commented on PR #1863:
URL: https://github.com/apache/incubator-seatunnel/pull/1863#issuecomment-1125627257
> I think how to translate can only be determined by the current engine. For example, on flink 1.11, SinkCommitter and SinkWriter cannot be converted separately.
> I think how to translate can only be determined by the current engine. For example, on flink 1.11, SinkCommitter and SinkWriter cannot be converted separately.
I think we should run it first, when we make this translation logic come true. And if like you say, we can't use converter logic in flink 1.11 and so on. I will change this to support that. But the common structure is more important in my view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun merged pull request #1863: [Api-draft] Support Spark Sink convert to SeaTunnel
Posted by GitBox <gi...@apache.org>.
ruanwenjun merged PR #1863:
URL: https://github.com/apache/incubator-seatunnel/pull/1863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org