[GitHub] [hadoop] timmylicheng commented on a change in pull request #1418: HDDS-2089: Add createPipeline CLI.

[GitBox <gi...@apache.org>]

timmylicheng commented on a change in pull request #1418: HDDS-2089: Add createPipeline CLI.
URL: https://github.com/apache/hadoop/pull/1418#discussion_r323611731
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java
 ##########
 @@ -390,10 +390,9 @@ public void notifyObjectStageChange(StorageContainerLocationProtocolProtos
   public Pipeline createReplicationPipeline(HddsProtos.ReplicationType type,
       HddsProtos.ReplicationFactor factor, HddsProtos.NodePool nodePool)
       throws IOException {
-    // TODO: will be addressed in future patch.
-    // This is needed only for debugging purposes to make sure cluster is
-    // working correctly.
-    return null;
+    AUDIT.logReadSuccess(
 
 Review comment:
   Updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org