You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2025/03/05 00:59:20 UTC
[kudu-CR](gh-pages) [site] Remove thirdparty resource references - take 2
Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22579
Change subject: [site] Remove thirdparty resource references - take 2
......................................................................
[site] Remove thirdparty resource references - take 2
This removes references to thirdparty hosted style sheets and adds
them into our repo. The license of the style sheets is public.
https://github.com/FortAwesome/Font-Awesome/blob/6.x/LICENSE.txt
https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css
Change-Id: I884be41c5e1e6d56ebdaf9b8ab22dc484801c5d0
---
M _includes/top_common.html
A css/bootstrap.min.css
A css/font-awesome.min.css
3 files changed, 12 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/22579/1
--
To view, visit http://gerrit.cloudera.org:8080/22579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I884be41c5e1e6d56ebdaf9b8ab22dc484801c5d0
Gerrit-Change-Number: 22579
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
[kudu-CR](gh-pages) [site] Remove thirdparty resource references - take 2
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22579 )
Change subject: [site] Remove thirdparty resource references - take 2
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I884be41c5e1e6d56ebdaf9b8ab22dc484801c5d0
Gerrit-Change-Number: 22579
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Comment-Date: Wed, 05 Mar 2025 18:06:41 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] Remove thirdparty resource references - take 2
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22579
to look at the new patch set (#2).
Change subject: [site] Remove thirdparty resource references - take 2
......................................................................
[site] Remove thirdparty resource references - take 2
This removes references to thirdparty hosted style sheets and adds
them into our repo. The license of the style sheets is public.
https://github.com/FortAwesome/Font-Awesome/blob/6.x/LICENSE.txt
https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css
A couple of older blog posts are updated where we refer to content from
thirparty sources.
Change-Id: I884be41c5e1e6d56ebdaf9b8ab22dc484801c5d0
---
M _includes/top_common.html
M _posts/2017-10-23-nosql-kudu-spanner-slides.md
M _posts/2018-07-10-instrumentation-in-kudu.md
A css/bootstrap.min.css
A css/font-awesome.min.css
A slides/kudu-spanner-slides
6 files changed, 1,393 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/22579/2
--
To view, visit http://gerrit.cloudera.org:8080/22579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I884be41c5e1e6d56ebdaf9b8ab22dc484801c5d0
Gerrit-Change-Number: 22579
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
[kudu-CR](gh-pages) [site] Remove thirdparty resource references - take 2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22579 )
Change subject: [site] Remove thirdparty resource references - take 2
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22579/2//COMMIT_MSG
Commit Message:
PS2:
Thank you for taking care of this, Abhishek!
Did you verify that it works as expected? If you are doing that on your laptop, I guess you could turn off WiFi (or otherwise disconnect from the network) and try to open up the top-level index.html in your browser, I guess.
Some of the Apache's logos and stickers might be off, but at least you could see whether the JS source is there or it attempts to fetch it from remote servers.
--
To view, visit http://gerrit.cloudera.org:8080/22579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I884be41c5e1e6d56ebdaf9b8ab22dc484801c5d0
Gerrit-Change-Number: 22579
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Comment-Date: Wed, 05 Mar 2025 04:38:35 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] Remove thirdparty resource references - take 2
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22579 )
Change subject: [site] Remove thirdparty resource references - take 2
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22579/2//COMMIT_MSG
Commit Message:
PS2:
> Thank you for taking care of this, Abhishek!
Yes,I tested this locally and I could see that I can load all the new CSS as expected.
--
To view, visit http://gerrit.cloudera.org:8080/22579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I884be41c5e1e6d56ebdaf9b8ab22dc484801c5d0
Gerrit-Change-Number: 22579
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Comment-Date: Wed, 05 Mar 2025 06:57:41 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] Remove thirdparty resource references - take 2
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22579 )
Change subject: [site] Remove thirdparty resource references - take 2
......................................................................
[site] Remove thirdparty resource references - take 2
This removes references to thirdparty hosted style sheets and adds
them into our repo. The license of the style sheets is public.
https://github.com/FortAwesome/Font-Awesome/blob/6.x/LICENSE.txt
https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css
A couple of older blog posts are updated where we refer to content from
thirparty sources.
Change-Id: I884be41c5e1e6d56ebdaf9b8ab22dc484801c5d0
Reviewed-on: http://gerrit.cloudera.org:8080/22579
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
---
M _includes/top_common.html
M _posts/2017-10-23-nosql-kudu-spanner-slides.md
M _posts/2018-07-10-instrumentation-in-kudu.md
A css/bootstrap.min.css
A css/font-awesome.min.css
A slides/kudu-spanner-slides
6 files changed, 1,393 insertions(+), 10 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Abhishek Chennaka: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: I884be41c5e1e6d56ebdaf9b8ab22dc484801c5d0
Gerrit-Change-Number: 22579
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
[kudu-CR](gh-pages) [site] Remove thirdparty resource references - take 2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22579 )
Change subject: [site] Remove thirdparty resource references - take 2
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I884be41c5e1e6d56ebdaf9b8ab22dc484801c5d0
Gerrit-Change-Number: 22579
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Comment-Date: Wed, 05 Mar 2025 07:11:27 +0000
Gerrit-HasComments: No