You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nafshartous <gi...@git.apache.org> on 2017/03/13 12:33:07 UTC
[GitHub] spark pull request #17275: SPARK-19767 Add not about missing API doc for Kaf...
GitHub user nafshartous opened a pull request:
https://github.com/apache/spark/pull/17275
SPARK-19767 Add not about missing API doc for Kafka 0.10 integration.
## What changes were proposed in this pull request?
Adding not about missing API docs for Kafka 0.10
## How was this patch tested?
Viewing generated doc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nafshartous/spark SPARK-19767
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17275
----
commit b986d26d6b16017b63d0e0b02e2b754fc1852bc8
Author: nafshartous <ni...@afshartous.com>
Date: 2017-03-13T12:28:18Z
SPARK-19767 Add not about missing API doc for Kafka 0.10 integration.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17275: SPARK-19767 Add note about missing API doc for Kafka 0.1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17275
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17275: SPARK-19767 Add note about missing API doc for Kafka 0.1...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17275
Sure you can update this branch too. Force push if you need to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17275: SPARK-19767 Add note about missing API doc for Kafka 0.1...
Posted by nafshartous <gi...@git.apache.org>.
Github user nafshartous commented on the issue:
https://github.com/apache/spark/pull/17275
Doc link is going to be changed to 0.10 artifact rather than 0.8 in a new PR to address this issue.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17275: SPARK-19767 Add note about missing API doc for Kafka 0.1...
Posted by nafshartous <gi...@git.apache.org>.
Github user nafshartous commented on the issue:
https://github.com/apache/spark/pull/17275
Looks like I need to remove the link to the Java source tree as the Java sources are generated not in github.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17275: SPARK-19767 Add note about missing API doc for Kafka 0.1...
Posted by nafshartous <gi...@git.apache.org>.
Github user nafshartous commented on the issue:
https://github.com/apache/spark/pull/17275
Should I submit a new PR or is it acceptable to resolve by adding more commits on this one ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17275: SPARK-19767 Add note about missing API doc for Kafka 0.1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17275
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17275: SPARK-19767 Add not about missing API doc for Kafka 0.10...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17275
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17275: SPARK-19767 Add note about missing API doc for Ka...
Posted by nafshartous <gi...@git.apache.org>.
Github user nafshartous closed the pull request at:
https://github.com/apache/spark/pull/17275
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17275: SPARK-19767 Add note about missing API doc for Kafka 0.1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17275
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17275: SPARK-19767 Add note about missing API doc for Kafka 0.1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17275
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17275: SPARK-19767 Add note about missing API doc for Kafka 0.1...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17275
It looks like the change got mangled, maybe due to line-ending differences? the diff shows the entire file as a change. Check the CRLF settings in git and try again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org