[GitHub] [yunikorn-core] wilfred-s commented on pull request #471: [YUNIKORN-1440][FOLLOWUP] Remove expired apps from queue during cleanup

[GitBox <gi...@apache.org>]

wilfred-s commented on PR #471:
URL: https://github.com/apache/yunikorn-core/pull/471#issuecomment-1345769875

   As I discussed with Brandon off-line: YUNIKORN-800 introduced this leak and did not take into account dynamic queues and application ID reuse (i.e. K8s CronJob).
   Completed applications should not be linked to the queue anymore. If we want them accessible based on the queue(path) we should allow a filter on the partition applications call.
   
   In the case that we have a dynamic queue: the queue will be removed long before the the completed application expires. Our main use cases have always used dynamic queues and that is one of the reasons why we did not see this issue. This is a workaround. It fixes the leak but nothing else. We should properly fix this the issues introduced in YUNIKORN-800 and the leak in one go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org