[GitHub] [iceberg] nastra commented on a diff in pull request #6168: Build: Bump jackson from 2.11.4 to 2.14.1

[GitBox <gi...@apache.org>]

nastra commented on code in PR #6168:
URL: https://github.com/apache/iceberg/pull/6168#discussion_r1035825038


##########
core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java:
##########
@@ -87,7 +88,41 @@ public static void registerAll(ObjectMapper mapper) {
     mapper.registerModule(module);
   }
 
-  public static class UpdateRequirementDeserializer extends JsonDeserializer<UpdateRequirement> {
+  // https://github.com/FasterXML/jackson-databind/commit/da339636d6a1db6fd618f1e59816fab3bb6d38d4
+  // added JacksonException to the throws declaration of JsonDeserializer#deserialize*(...)
+  // The purpose of this class is so that we don't propagate this API-breaking throws-change to any
+  // Iceberg clients

Review Comment:
   Basically RevAPI complains that `throws java.io.IOException` changed to `throws java.io.IOException, com.fasterxml.jackson.core.JacksonException` due to the Jackson version bump. 
   I think RevAPI doesn't care that `JacksonException` itself is a subclass of `IOException` and just complains about the signature change.
   
   That's why we're introducing a middle class that only defines `throws java.io.IOException` on those methods. Alternatively, we could have added those RevAPI breaks as accepted breaks but that didn't seem like the better approach to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org