You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/03/26 20:55:20 UTC
[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4548: Can change any
type's useInTable value to be server
ZugNZwang opened a new issue #4548: Can change any type's useInTable value to be server
URL: https://github.com/apache/trafficcontrol/issues/4548
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
<!--
- For *SUPPORT QUESTIONS*, use the
[Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
## I'm submitting a ...
<!-- (check all that apply with "[x]") -->
<!--- security vulnerability (STOP!! - see above)-->
- [X] bug report
- [ ] new feature / enhancement request
- [ ] improvement request (usability, performance, tech debt, etc.)
- [ ] other <!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- (check all that apply with "[x]") -->
- [ ] CDN in a Box
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Control Client
- [ ] Traffic Monitor
- [X] Traffic Ops
- [ ] Traffic Ops ORT
- [ ] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] unknown
## Current behavior:
<!-- Describe how the bug manifests / how the current features are insufficient. -->
When making a `PUT` request to `/types/{id}`, where `id` identifies a type that **does not** belong in the servers table. The API allows that type to be changed from the table it was using. For example one can update a type using the deliveryservice table to use the server table.
```http
HTTP/1.1 200 OK
Content-Type: application/json
{
"alerts": [
{
"text": "type was updated.",
"level": "success"
}
],
"response": {
"id": 1,
"lastUpdated": "2020-03-26 20:49:44+00",
"name": "HTTP",
"description": "HTTP Content Routing",
"useInTable": "server"
}
}
```
## Expected / new behavior:
<!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
Should not be allowed and return:
```http
HTTP/1.1 400 Bad Request
Content-Type: application/json
{
"alerts": [
{
"text": "can not update type",
"level": "error"
}
]
}
```
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
-->
## Anything else:
<!-- e.g. stacktraces, related issues, suggestions how to fix -->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #4548: Can change
any type's useInTable value to be server
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4548: Can change any type's useInTable value to be server
URL: https://github.com/apache/trafficcontrol/issues/4548#issuecomment-604696731
Yeah, I think you should only be able to:
a. create a type with useintable=server (any other values for useintable should be rejected)
b. update a type where useintable=server but can't change the useintable value to something else.
c. delete a type where useintable=server
imo this should all be enforced at the api level. UI level is a bonus maybe but not really necessary.
fyi, the useintable thing is very strange...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services