[GitHub] [hive] kasakrisz commented on a diff in pull request #3461: HIVE-26417: Iceberg integration: disable update and merge iceberg table when split update is off

[GitBox <gi...@apache.org>]

kasakrisz commented on code in PR #3461:
URL: https://github.com/apache/hive/pull/3461#discussion_r927521734


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -62,11 +62,10 @@ protected ASTNode getTargetTableNode(ASTNode tree) {
 
   @Override
   public void analyze(ASTNode tree, Table targetTable, ASTNode tableNameNode) throws SemanticException {
-    if (tree.getToken().getType() != HiveParser.TOK_MERGE) {
-      throw new RuntimeException("Asked to parse token " + tree.getName() + " in " +
-          "MergeSemanticAnalyzer");
+    boolean nonNativeAcid = AcidUtils.isNonNativeAcidTable(targetTable);
+    if (nonNativeAcid) {

Review Comment:
   It is already implemented and used independently from this patch. `HiveIcebergStorageHandler.fallbackToNonVectorizedModeBasedOnProperties` is called when FSOperator "augments the plan"
   https://github.com/apache/hive/blob/4146d220bfc0a29d117676844a4c7021fcc6a30d/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java#L1612



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org