[GitHub] [samza] kw2542 commented on pull request #1400: SAMZA-2558: Refactor app.runner.class

[GitBox <gi...@apache.org>]

kw2542 commented on pull request #1400:
URL: https://github.com/apache/samza/pull/1400#issuecomment-659051643


   > Why is `ApplicationRunners` being moved out of samza-api? Is it so it can depend on the `ApplicationConfig` class?
   > It seems to me like `ApplicationRunners` is intended to be part of the API so that it can be used to help launch apps. If we expect a class to be able to be called by users, then it should not be in samza-core, since users should not need to depend on samza-core in general.
   > The placement of classes in samza-api vs. samza-core is useful because we can have different evolution rules for different parts of code. We need to generally evolve samza-api classes in a backwards compatible way since they are API, but we have more flexibility for samza-core classes since they aren't considered part of the API.
   
   Good question. IMO,  `ApplicationRunners` only contains a single method `getApplicationRunner` which constructs the an `ApplicationRunner` with reflection. I would expect `ApplicationRunnerUtil#invoke` is the actual method help users to launch application instead of `ApplicationRunners`. What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org