You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rave.apache.org by Stanton Sievers <si...@gmail.com> on 2014/01/26 00:46:16 UTC

Review Request 17357: Cloned pages do not get page properties

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17357/
-----------------------------------------------------------

Review request for rave.


Bugs: RAVE-1085
    https://issues.apache.org/jira/browse/RAVE-1085


Repository: rave


Description
-------

The clone operation does not copy page properties.

The issue is that the properties were being set prior to retrieving the page, thus the properties were getting overwritten.


Diffs
-----

  https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPageService.java 1561424 

Diff: https://reviews.apache.org/r/17357/diff/


Testing
-------

Existing unit tests pass.  Verified page properties get cloned in a custom portal.


Thanks,

Stanton Sievers

Re: Review Request 17357: Cloned pages do not get page properties

Posted by Matt Franklin <mf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17357/#review32874
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Franklin


On Jan. 25, 2014, 11:46 p.m., Stanton Sievers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17357/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2014, 11:46 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Bugs: RAVE-1085
>     https://issues.apache.org/jira/browse/RAVE-1085
> 
> 
> Repository: rave
> 
> 
> Description
> -------
> 
> The clone operation does not copy page properties.
> 
> The issue is that the properties were being set prior to retrieving the page, thus the properties were getting overwritten.
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultPageService.java 1561424 
> 
> Diff: https://reviews.apache.org/r/17357/diff/
> 
> 
> Testing
> -------
> 
> Existing unit tests pass.  Verified page properties get cloned in a custom portal.
> 
> 
> Thanks,
> 
> Stanton Sievers
> 
>