You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Matthias Bläsing <mb...@doppel-helix.eu.INVALID> on 2023/05/23 19:20:06 UTC
[DISCUSS] Release Apache NetBeans 18: ConcurrentModificationException from javascript scanning
Hi all,
testing the voting candidate, I noticed, that the JS scanning can run
into a ConcurrentModificationException. The issue will cause an
exception to be raised when scanning a construct like this:
export class test {
field1 = "Value1";
method1() {
}
}
I did not catch this earlier as I'm running with a private plugin that
excludes node_modules folder from JS scanning and did insufficient
testing when integrating the fix, that enabled accessing members from
"export class" constructs.
A fix is here:
https://github.com/apache/netbeans/pull/5983
It applies the pattern that is used in other places, where the property
copy code is invoked.
For me this is not a big problem as described above, but people using
plain JS in the IDE might face bigger problems. At least the message
log gets flooded and of of course you'll get annoying exception
bubbles.
Sorry about that.
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [DISCUSS] Release Apache NetBeans 18: ConcurrentModificationException from javascript scanning
Posted by Antonio <an...@vieiro.net.INVALID>.
There's a typo here, I think:
When you say "I should have done it in RC" you should be probably saying
"_we_ should have done it in RC".
Cheers,
Antonio
On 24/5/23 18:33, Matthias Bläsing wrote:
> This is in the voting instructions:
>
> [...] As well as checking any artefact functions correctly [...]
>
> Well, that was what I have been doing and yes I should have done it in
> RC.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [DISCUSS] Release Apache NetBeans 18: ConcurrentModificationException from javascript scanning
Posted by Michael Bien <mb...@gmail.com>.
On 24.05.23 19:18, Neil C Smith wrote:
> On Wed, 24 May 2023 at 17:33, Matthias Bläsing
> <mb...@doppel-helix.eu.invalid> wrote:
>> Am Mittwoch, dem 24.05.2023 um 08:51 -0700 schrieb dev@netbeans.apache.org:
>>> I'd proceed as is, document that on the release notes. If there would be
>>> many complaints, I might consider to do a 18u1 nbm release.
>> oh nameless one, want to say who you are? But in general I agree.
> Seconded. We've had an anonymous message like this before, so I'd be
> interested in who, and how?
that is probably Laszlo :)
chatted about this on slack with him a few weeks ago, there is something
wrong with his setup.
-mbien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [DISCUSS] Release Apache NetBeans 18: ConcurrentModificationException from javascript scanning
Posted by Neil C Smith <ne...@apache.org>.
On Wed, 24 May 2023 at 17:33, Matthias Bläsing
<mb...@doppel-helix.eu.invalid> wrote:
> Am Mittwoch, dem 24.05.2023 um 08:51 -0700 schrieb dev@netbeans.apache.org:
> > I'd proceed as is, document that on the release notes. If there would be
> > many complaints, I might consider to do a 18u1 nbm release.
>
> oh nameless one, want to say who you are? But in general I agree.
Seconded. We've had an anonymous message like this before, so I'd be
interested in who, and how?
> > On 5/24/23 01:25, Neil C Smith wrote:
> > Voting candidates should not need to be tested for functionality.
>
> This is in the voting instructions:
>
> [...] As well as checking any artefact functions correctly [...]
>
> Well, that was what I have been doing and yes I should have done it in
> RC.
Yes, sorry, badly worded comment. The last RC and release vote build
are always off the same git hash. So we're just trying to encourage
people to do the bulk of their usage testing, including prior testing
of source builds, on the RCs.
The key functionality check for artefacts in the vote is do they
build, package or install the right thing, correctly, and give you
something identical to the last RC except for the versions.
Which is not to say we shouldn't pull a vote if a big enough issue is
only noticed at that stage, and obviously we have before. I'm curious
that no-one, not just you particularly, has picked up on and reported
this one though? It's perhaps a gap in who is testing what during the
RC phase of releases?
Best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [DISCUSS] Release Apache NetBeans 18: ConcurrentModificationException from javascript scanning
Posted by Matthias Bläsing <mb...@doppel-helix.eu.INVALID>.
Hi,
Am Mittwoch, dem 24.05.2023 um 08:51 -0700 schrieb dev@netbeans.apache.org:
> I'd proceed as is, document that on the release notes. If there would be
> many complaints, I might consider to do a 18u1 nbm release.
oh nameless one, want to say who you are? But in general I agree.
> On 5/24/23 01:25, Neil C Smith wrote:
> > On Tue, 23 May 2023 at 20:20, Matthias Bläsing
> > <mb...@doppel-helix.eu.invalid> wrote:
> > > testing the voting candidate, I noticed, that the JS scanning can run
> > > into a ConcurrentModificationException.
> > ...
> > > For me this is not a big problem as described above, but people using
> > > plain JS in the IDE might face bigger problems. At least the message
> > > log gets flooded and of of course you'll get annoying exception
> > > bubbles.
> > >
> > > Sorry about that.
> > That's fine! It happens. But this is a discussion thread, so what
> > exactly are we discussing? How do you think we should proceed?
I wanted to make people aware. If noone cares in the Vote, then it is
not a problem. Now at least noone can say "Oh, that is surprising,
damn...".
> > I'm also concerned why this hasn't been picked up during the release
> > candidate phase? Those are cheap to produce, voting candidates are
> > not. In particular now we've moved to a consolidated vote. Are there
> > things we could improve in our RC testing? Voting candidates should
> > not need to be tested for functionality.
This is in the voting instructions:
[...] As well as checking any artefact functions correctly [...]
Well, that was what I have been doing and yes I should have done it in
RC.
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [DISCUSS] Release Apache NetBeans 18: ConcurrentModificationException from javascript scanning
Posted by de...@netbeans.apache.org.
I'd proceed as is, document that on the release notes. If there would be
many complaints, I might consider to do a 18u1 nbm release.
On 5/24/23 01:25, Neil C Smith wrote:
> On Tue, 23 May 2023 at 20:20, Matthias Bläsing
> <mb...@doppel-helix.eu.invalid> wrote:
>> testing the voting candidate, I noticed, that the JS scanning can run
>> into a ConcurrentModificationException.
> ...
>> For me this is not a big problem as described above, but people using
>> plain JS in the IDE might face bigger problems. At least the message
>> log gets flooded and of of course you'll get annoying exception
>> bubbles.
>>
>> Sorry about that.
> That's fine! It happens. But this is a discussion thread, so what
> exactly are we discussing? How do you think we should proceed?
>
> I guess there are at least 3 choices -
>
> 1. Pull the vote. Doing that means throwing away about 8-10 hours of
> work across 4 people, and will delay the release by a couple of weeks.
>
> 2. Do an 18-u1 release in a couple of weeks to push this fix, and any
> others that arise, via the update centres. Do we have a volunteer to
> RM? I'll help if need be, but won't be able to put much time into it.
>
> 3. Proceed as is, and provide information on how to mitigate the issue.
>
> I'm also concerned why this hasn't been picked up during the release
> candidate phase? Those are cheap to produce, voting candidates are
> not. In particular now we've moved to a consolidated vote. Are there
> things we could improve in our RC testing? Voting candidates should
> not need to be tested for functionality.
>
> Thanks and best wishes,
>
> Neil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [DISCUSS] Release Apache NetBeans 18: ConcurrentModificationException from javascript scanning
Posted by Neil C Smith <ne...@apache.org>.
On Tue, 23 May 2023 at 20:20, Matthias Bläsing
<mb...@doppel-helix.eu.invalid> wrote:
> testing the voting candidate, I noticed, that the JS scanning can run
> into a ConcurrentModificationException.
...
> For me this is not a big problem as described above, but people using
> plain JS in the IDE might face bigger problems. At least the message
> log gets flooded and of of course you'll get annoying exception
> bubbles.
>
> Sorry about that.
That's fine! It happens. But this is a discussion thread, so what
exactly are we discussing? How do you think we should proceed?
I guess there are at least 3 choices -
1. Pull the vote. Doing that means throwing away about 8-10 hours of
work across 4 people, and will delay the release by a couple of weeks.
2. Do an 18-u1 release in a couple of weeks to push this fix, and any
others that arise, via the update centres. Do we have a volunteer to
RM? I'll help if need be, but won't be able to put much time into it.
3. Proceed as is, and provide information on how to mitigate the issue.
I'm also concerned why this hasn't been picked up during the release
candidate phase? Those are cheap to produce, voting candidates are
not. In particular now we've moved to a consolidated vote. Are there
things we could improve in our RC testing? Voting candidates should
not need to be tested for functionality.
Thanks and best wishes,
Neil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists