You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@doris.apache.org by GitBox <gi...@apache.org> on 2018/11/29 07:14:56 UTC
[GitHub] imay commented on a change in pull request #367: Fix a sending
signal error when starting Doris BE
imay commented on a change in pull request #367: Fix a sending signal error when starting Doris BE
URL: https://github.com/apache/incubator-doris/pull/367#discussion_r237373788
##########
File path: bin/start_be.sh
##########
@@ -55,14 +55,14 @@ rm -f ${UDF_RUNTIME_DIR}/*
pidfile=$PID_DIR/be.pid
if [ -f $pidfile ]; then
- if kill -0 $(cat $pidfile); then
+ if [ -d /proc/$(cat $pidfile) ]; then
Review comment:
proc filesystem maybe not mount in some environment.
can you change it to
```suggestion
if kill -0 $(cat $pidfile) > /dev/null 2>&1; then
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org