You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/02/28 00:17:59 UTC
[GitHub] npawar opened a new pull request #3893: Reduce
MAX_SEGMENT_COMPLETION_TIME_MILLIS to 5 minutes
npawar opened a new pull request #3893: Reduce MAX_SEGMENT_COMPLETION_TIME_MILLIS to 5 minutes
URL: https://github.com/apache/incubator-pinot/pull/3893
Reducing MAX_SEGMENT_COMPLETION_TIME_MILLIS from 10 minutes to 5 (and possibly lower in the future). 10 minutes is a lot for segment completion. This 10 minutes gets added into our SLA of being able to fix consuming partitions, no matter how fast we can run RealtimeSegmentValidationManager.
Reducing this time will increase the chance of RealtimeSegmentValidationManager fixing a segment in ideal state, because the ideal state update took too long in the regular segment commit path (gc, zk issue, etc). Added a change to prevent over-writing the new segment's ideal state update in segment commit, if it already exists in ideal state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org