You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by shawnfeldman <gi...@git.apache.org> on 2015/01/27 17:16:06 UTC
[GitHub] incubator-usergrid pull request: remove lexer from ignore
GitHub user shawnfeldman opened a pull request:
https://github.com/apache/incubator-usergrid/pull/155
remove lexer from ignore
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-usergrid remove-queryfilterlexer-from-ignore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-usergrid/pull/155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #155
----
commit df29a99c4218a39269151a8773c0b0e051507650
Author: Shawn Feldman <sf...@apache.org>
Date: 2015-01-27T16:11:04Z
remove lexer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: remove lexer from ignore
Posted by snoopdave <gi...@git.apache.org>.
Github user snoopdave commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/155#issuecomment-71677367
Gotcha. Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: remove lexer from ignore
Posted by snoopdave <gi...@git.apache.org>.
Github user snoopdave commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/155#issuecomment-71676204
Do the generated lexer files really belong in source code control? I'd rather see the lexer classes generated into a temporary directory like target/generated-classes. They are just build artifacts not really our source code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: remove lexer from ignore
Posted by shawnfeldman <gi...@git.apache.org>.
Github user shawnfeldman commented on the pull request:
https://github.com/apache/incubator-usergrid/pull/155#issuecomment-71676640
removed too many line
the core ones aren't in two-0 and are confusing when you switch branches
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: remove lexer from ignore
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-usergrid/pull/155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---