[GitHub] [accumulo] ctubbsii commented on a change in pull request #1579: Closes #1576: Update importTable with directory list as Set

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1579: Closes #1576: Update importTable with directory list as Set<String>
URL: https://github.com/apache/accumulo/pull/1579#discussion_r404495656
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
 ##########
 @@ -176,11 +176,11 @@ void create(String tableName, NewTableConfiguration ntc)
    *
    * @param tableName
    *          Name of a table to create and import into.
-   * @param importDir
-   *          Directory that contains the files copied by distcp from exportTable
+   * @param importDirs
+   *          A set of directories containing the files copied by distcp from exportTable
    * @since 1.5.0
    */
-  void importTable(String tableName, String importDir)
+  void importTable(String tableName, Set<String> importDirs)
 
 Review comment:
   This is public API and cannot change without a deprecation cycle.
   A new API is needed, which should co-exist with this one, until this one is removed.
   I didn't look at the rest of this PR, since this is a blocker right away.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services