[jira] [Commented] (MAPREDUCE-4305) Implement delay scheduling in capacity scheduler for improving data locality

["Karthik Kambatla (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643162#comment-13643162 ] 

Karthik Kambatla commented on MAPREDUCE-4305:
---------------------------------------------

Thanks Mayank. From a logic point of view, the code looks good.

Have a few nits, mostly formatting:
# The patch has a few unrelated diffs - mostly whitespace and formatting changes[
# Definition of {{SKIP_SCHEDULING_TIMES}} seems way over 80 chars - can we wrap it around?
# Formatting seems off at
{code}long numActiveNodesinCluster = scheduler.taskTrackerManager
      .getClusterStatus().getTaskTrackers()
      - scheduler.taskTrackerManager.getClusterStatus()
      .getGraylistedTrackers();
{code}
# Switch statement in {{getAllowedLocalityLevel()}} has a few statements over 80 chars
# LocalityStage javadoc refers to FairScheduler
# In TestCapacityScheduler, formatting in method parameters of {{obtain*MapTask}}: no space after comma
                
> Implement delay scheduling in capacity scheduler for improving data locality
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4305
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4305
>             Project: Hadoop Map/Reduce
>          Issue Type: New Feature
>            Reporter: Mayank Bansal
>            Assignee: Mayank Bansal
>         Attachments: MAPREDUCE-4305, MAPREDUCE-4305-1.patch, PATCH-MAPREDUCE-4305-MR1-1.patch, PATCH-MAPREDUCE-4305-MR1-2.patch, PATCH-MAPREDUCE-4305-MR1-3.patch, PATCH-MAPREDUCE-4305-MR1.patch
>
>
> Capacity Scheduler data local tasks are about 40%-50% which is not good.
> While my test with 70 node cluster i consistently get data locality around 40-50% on a free cluster.
> I think we need to implement something like delay scheduling in the capacity scheduler for improving the data locality.
> http://radlab.cs.berkeley.edu/publication/308
> After implementing the delay scheduling on Hadoop 22 I am getting 100 % data locality in free cluster and around 90% data locality in busy cluster.
> Thanks,
> Mayank

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira