You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/03/06 20:53:24 UTC

[GitHub] [phoenix] kadirozde commented on a change in pull request #725: PHOENIX-5749: Add unit tests for verifySingleIndexRow() of IndexRebui…

kadirozde commented on a change in pull request #725: PHOENIX-5749: Add unit tests for verifySingleIndexRow() of IndexRebui…
URL: https://github.com/apache/phoenix/pull/725#discussion_r389138519
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
 ##########
 @@ -109,231 +110,6 @@
 
 public class IndexRebuildRegionScanner extends BaseRegionScanner {
 
-    public static class VerificationResult {
 
 Review comment:
   Why do you need to move this code out from this file? It is a static helper class and only meaningful in the context of index verification and not by itself.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services