You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by lisakowen <gi...@git.apache.org> on 2016/09/16 00:26:17 UTC
[GitHub] incubator-hawq pull request #903: improve hawq check command line help
GitHub user lisakowen opened a pull request:
https://github.com/apache/incubator-hawq/pull/903
improve hawq check command line help
- add several missing options
- update content for accuracy and clarity
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lisakowen/incubator-hawq feature/hawqcheck-help
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/903.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #903
----
commit 5abaea162e4f9080897503fd3dafc440ebe5293a
Author: Lisa Owen <lo...@pivotal.io>
Date: 2016-09-15T23:53:04Z
improve hawq check command line help
- add several missing options
- update content for accuracy and clarity
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #903: HAWQ-1056 - improve hawq check command lin...
Posted by lisakowen <gi...@git.apache.org>.
Github user lisakowen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/903#discussion_r97809101
--- Diff: tools/doc/gpcheck_help ---
@@ -135,27 +142,27 @@ OPTIONS
EXAMPLES
*****************************************************
-Verify and validate the HAWQ platform settings by
-entering a host file and specifying the hadoop location:
+Verify and validate the HAWQ platform settings by specifying
+a host file and identifying the full hadoop install path:
- # hawq check -f hostfile_hawq_check --hadoop ~/hadoop-2.0.0/
+ # hawq check -f hostfile_hawq_check --hadoop /usr/hdp/<version>/hadoop/
--- End diff --
thanks for reviewing @radarwave. i used both local and hdp in the directory paths to distinguish between a product hadoop installation and an open source version. i agree it is kind of confusing. i will have both examples use local.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #903: HAWQ-1056 - improve hawq check command line help
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-hawq/pull/903
One thing I would suggest is to be consistent in the use of the "<" and ">" characters used in the synopsis as the detailed option description. As an example, the string "--config config_file" should instead be "--config <config_file>" to be consistent with the synopsis. BTW: this would make it consistent with the docs as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #903: HAWQ-1056 - improve hawq check command line help
Posted by lisakowen <gi...@git.apache.org>.
Github user lisakowen commented on the issue:
https://github.com/apache/incubator-hawq/pull/903
@liming01 @wengyanqing @stanlyxiang - thank you for noting that i did not follow the appropriate PR conventions. i will make sure to squash commits and include the JIRA number in the commit message in future PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #903: HAWQ-1056 - improve hawq check command lin...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/903#discussion_r102407104
--- Diff: tools/doc/gpcheck_help ---
@@ -135,27 +142,27 @@ OPTIONS
EXAMPLES
*****************************************************
-Verify and validate the HAWQ platform settings by
-entering a host file and specifying the hadoop location:
+Verify and validate the HAWQ platform settings by specifying
+a host file and identifying the full hadoop install path:
- # hawq check -f hostfile_hawq_check --hadoop ~/hadoop-2.0.0/
+ # hawq check -f hostfile_hawq_check --hadoop /usr/hdp/<version>/hadoop/
Verify and validate the HAWQ platform settings with HDFS HA
-enabled, YARN HA enabled and Kerberos enabled:
+enabled, YARN HA enabled, and Kerberos enabled:
- # hawq check -f hostfile_hawq_check --hadoop ~/hadoop-2.0.0/
+ # hawq check -f hostfile_hawq_check --hadoop /usr/local/hadoop-<version>/
--- End diff --
hdp should probably not be in the open source doc. I think it is fine for the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #903: HAWQ-1056 - improve hawq check command line help
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-hawq/pull/903
@lisakowen - Do you still need a review for this PR? The PR and Jira have been open for a while without any activity (Sep 2016).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #903: HAWQ-1056 - improve hawq check command line help
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the issue:
https://github.com/apache/incubator-hawq/pull/903
Hi @lisakowen , please add HAWQ-1056 prefix to commit message, so that we can easily track the apache jira and related fix.
If you don't open any apache jira for doc change, then maybe a simple and help prefix can be used, eg. "Doc updated: ... "
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #903: HAWQ-1056 - improve hawq check command lin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/903
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #903: HAWQ-1056 - improve hawq check command line help
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-hawq/pull/903
If you could refresh this PR with my comment above, I can review one last time and we can get this merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #903: HAWQ-1056 - improve hawq check command lin...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/903#discussion_r97697524
--- Diff: tools/doc/gpcheck_help ---
@@ -135,27 +142,27 @@ OPTIONS
EXAMPLES
*****************************************************
-Verify and validate the HAWQ platform settings by
-entering a host file and specifying the hadoop location:
+Verify and validate the HAWQ platform settings by specifying
+a host file and identifying the full hadoop install path:
- # hawq check -f hostfile_hawq_check --hadoop ~/hadoop-2.0.0/
+ # hawq check -f hostfile_hawq_check --hadoop /usr/hdp/<version>/hadoop/
--- End diff --
We have both '/usr/hdp/<version>/hadoop/' and '/usr/local/hadoop-<version>/'. Maybe we should make them the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #903: HAWQ-1056 - improve hawq check command line help
Posted by lisakowen <gi...@git.apache.org>.
Github user lisakowen commented on the issue:
https://github.com/apache/incubator-hawq/pull/903
yes, need a review for this PR.
wasn't sure how to rerun the tests - i think the travis failure is
transient/unrelated to the changes. also wasn't sure how to determine if
there were any tests that compared command line help output, and where i
might look to figure that out.
thanks ed.
On Tue, Jan 17, 2017 at 11:49 AM, Ed Espino <no...@github.com>
wrote:
> @lisakowen <https://github.com/lisakowen> - Do you still need a review
> for this PR? The PR and Jira have been open for a while without any
> activity (Sep 2016).
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-hawq/pull/903#issuecomment-273279109>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AS3odVwNdEpCypYppaPfC1V7B09p9mpmks5rTRtfgaJpZM4J-fd4>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #903: HAWQ-1056 - improve hawq check command line help
Posted by lisakowen <gi...@git.apache.org>.
Github user lisakowen commented on the issue:
https://github.com/apache/incubator-hawq/pull/903
@edespino - thanks for reviewing. i added <> around the option arguments as you suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #903: HAWQ-1056 - improve hawq check command lin...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/903#discussion_r97697509
--- Diff: tools/doc/gpcheck_help ---
@@ -135,27 +142,27 @@ OPTIONS
EXAMPLES
*****************************************************
-Verify and validate the HAWQ platform settings by
-entering a host file and specifying the hadoop location:
+Verify and validate the HAWQ platform settings by specifying
+a host file and identifying the full hadoop install path:
- # hawq check -f hostfile_hawq_check --hadoop ~/hadoop-2.0.0/
+ # hawq check -f hostfile_hawq_check --hadoop /usr/hdp/<version>/hadoop/
Verify and validate the HAWQ platform settings with HDFS HA
-enabled, YARN HA enabled and Kerberos enabled:
+enabled, YARN HA enabled, and Kerberos enabled:
- # hawq check -f hostfile_hawq_check --hadoop ~/hadoop-2.0.0/
+ # hawq check -f hostfile_hawq_check --hadoop /usr/local/hadoop-<version>/
--- End diff --
We have both '/usr/hdp/<version>/hadoop/' and '/usr/local/hadoop-<version>/'. Maybe we should make them the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #903: HAWQ-1056 - improve hawq check command line help
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/903
@radarwave
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---