You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by jm...@apache.org on 2009/07/06 01:47:57 UTC
svn commit: r791343 -
/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
Author: jmorales
Date: Sun Jul 5 23:47:56 2009
New Revision: 791343
URL: http://svn.apache.org/viewvc?rev=791343&view=rev
Log:
[CONTINUUM-2228] Edit Project Group Summary Removes Local Repository.
In select field can't select empty value but if user don't allowed edit repositories, then repositoryId = 0 and set null value.
Modified:
continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
Modified: continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
URL: http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java?rev=791343&r1=791342&r2=791343&view=diff
==============================================================================
--- continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java (original)
+++ continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java Sun Jul 5 23:47:56 2009
@@ -482,15 +482,12 @@
projectGroup.setDescription( description );
+ // [CONTINUUM-2228]. In select field can't select empty values.
if ( repositoryId > 0 )
{
LocalRepository repository = getContinuum().getRepositoryService().getLocalRepository( repositoryId );
projectGroup.setLocalRepository( repository );
}
- else
- {
- projectGroup.setLocalRepository( null );
- }
getContinuum().updateProjectGroup( projectGroup );
Re: svn commit: r791343 - /continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
Posted by Wendy Smoak <ws...@gmail.com>.
2009/7/6 José Morales Martínez <jm...@gmv.com>:
> I forgot in the commit description referencer "Submitted By". How can I
> include the summit value now (Add ""Submitted By" reference in commit where I add this user to contributors list ?) ?.
You can fix the commit log message after the fact with "svn propedit
--revprop -r12345 svn:log" ('svn help propedit' for more info.)
> About add user to the contributor list, I thought this decision could only be taken by PMCs.
> Do I have to ask for ICLA and then add to contributor list?
We keep a list of contributors in the Continuum parent pom. These are
not committers who have access to the source code, which does require
a vote. If the contribution is large, I do ask for an iCLA before
applying the patch. In this case it was a few lines, so not necessary
imo.
Thanks,
--
Wendy
RE: svn commit: r791343 -
/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
Posted by José Morales Martínez <jm...@gmv.com>.
I forgot in the commit description referencer "Submitted By". How can I
include the summit value now (Add ""Submitted By" reference in commit where I add this user to contributors list ?) ?.
About add user to the contributor list, I thought this decision could only be taken by PMCs.
Do I have to ask for ICLA and then add to contributor list?
---
Jose.
________________________________________
De: Marica Tan [marica.tan@gmail.com]
Enviado el: lunes, 06 de julio de 2009 4:19
Para: dev@continuum.apache.org
Asunto: Re: svn commit: r791343 - /continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
Hi Jose,
Can you include the "Submitted By" if this is the patch submitted by
deckrider. Also add him to the list of contributors :)
Thanks,
--
Marica
On Mon, Jul 6, 2009 at 7:47 AM, <jm...@apache.org> wrote:
> Author: jmorales
> Date: Sun Jul 5 23:47:56 2009
> New Revision: 791343
>
> URL: http://svn.apache.org/viewvc?rev=791343&view=rev
> Log:
> [CONTINUUM-2228] Edit Project Group Summary Removes Local Repository.
>
> In select field can't select empty value but if user don't allowed edit
> repositories, then repositoryId = 0 and set null value.
>
> Modified:
>
> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
>
> Modified:
> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
> URL:
> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java?rev=791343&r1=791342&r2=791343&view=diff
>
> ==============================================================================
> ---
> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
> (original)
> +++
> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
> Sun Jul 5 23:47:56 2009
> @@ -482,15 +482,12 @@
>
> projectGroup.setDescription( description );
>
> + // [CONTINUUM-2228]. In select field can't select empty values.
> if ( repositoryId > 0 )
> {
> LocalRepository repository =
> getContinuum().getRepositoryService().getLocalRepository( repositoryId );
> projectGroup.setLocalRepository( repository );
> }
> - else
> - {
> - projectGroup.setLocalRepository( null );
> - }
>
> getContinuum().updateProjectGroup( projectGroup );
>
>
>
>
______________________
Este mensaje, y en su caso, cualquier fichero anexo al mismo,
puede contener informacion clasificada por su emisor como confidencial
en el marco de su Sistema de Gestion de Seguridad de la
Informacion siendo para uso exclusivo del destinatario, quedando
prohibida su divulgacion copia o distribucion a terceros sin la
autorizacion expresa del remitente. Si Vd. ha recibido este mensaje
erroneamente, se ruega lo notifique al remitente y proceda a su borrado.
Gracias por su colaboracion.
______________________
This message including any attachments may contain confidential
information, according to our Information Security Management System,
and intended solely for a specific individual to whom they are addressed.
Any unauthorised copy, disclosure or distribution of this message
is strictly forbidden. If you have received this transmission in error,
please notify the sender immediately and delete it.
______________________
Re: svn commit: r791343 - /continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
Posted by Marica Tan <ma...@gmail.com>.
Hi Jose,
Can you include the "Submitted By" if this is the patch submitted by
deckrider. Also add him to the list of contributors :)
Thanks,
--
Marica
On Mon, Jul 6, 2009 at 7:47 AM, <jm...@apache.org> wrote:
> Author: jmorales
> Date: Sun Jul 5 23:47:56 2009
> New Revision: 791343
>
> URL: http://svn.apache.org/viewvc?rev=791343&view=rev
> Log:
> [CONTINUUM-2228] Edit Project Group Summary Removes Local Repository.
>
> In select field can't select empty value but if user don't allowed edit
> repositories, then repositoryId = 0 and set null value.
>
> Modified:
>
> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
>
> Modified:
> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
> URL:
> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java?rev=791343&r1=791342&r2=791343&view=diff
>
> ==============================================================================
> ---
> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
> (original)
> +++
> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ProjectGroupAction.java
> Sun Jul 5 23:47:56 2009
> @@ -482,15 +482,12 @@
>
> projectGroup.setDescription( description );
>
> + // [CONTINUUM-2228]. In select field can't select empty values.
> if ( repositoryId > 0 )
> {
> LocalRepository repository =
> getContinuum().getRepositoryService().getLocalRepository( repositoryId );
> projectGroup.setLocalRepository( repository );
> }
> - else
> - {
> - projectGroup.setLocalRepository( null );
> - }
>
> getContinuum().updateProjectGroup( projectGroup );
>
>
>
>