[jira] [Commented] (KARAF-4537) Karaf Maven Plugin should repsect scope when building a feature

["Alexander Rotnov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390845#comment-15390845 ] 

Alexander Rotnov commented on KARAF-4537:
-----------------------------------------

Looking at source code, I found plugin already has this logic (GenerateDescriptorMojo, line 374):
if ("runtime".equals(entry.getValue())) {
      bundle.setDependency(true);
}
but this clause never reached, because runtime and provided dependencies are not collected during execution, all of them is not selected by ScopeDependencySelector1. And its seems like a bug.

> Karaf Maven Plugin should repsect scope when building a feature
> ---------------------------------------------------------------
>
>                 Key: KARAF-4537
>                 URL: https://issues.apache.org/jira/browse/KARAF-4537
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf-tooling
>    Affects Versions: 4.0.5
>            Reporter: Viktor Kozlov
>             Fix For: 4.1.0, 4.0.6
>
>
> I am building a feature without a feature template file. I list my feature content via pom dependencies.
> For example:
>     <dependencies>
>         <dependency>
>             <groupId>org.apache.geronimo.specs</groupId>
>             <artifactId>geronimo-validation_1.1_spec</artifactId>
>             <scope>compile</scope>
>         </dependency>
>         <dependency>
>             <groupId>org.apache.geronimo.specs</groupId>
>             <artifactId>geronimo-el_2.2_spec</artifactId>
>             <scope>compile</scope>
>         </dependency>
>         <dependency>
>             <groupId>commons-collections</groupId>
>             <artifactId>commons-collections</artifactId>
>             <scope>compile</scope>
>         </dependency>
>         <dependency>
>             <groupId>commons-beanutils</groupId>
>             <artifactId>commons-beanutils</artifactId>
>             <scope>compile</scope>
>         </dependency>
>         <dependency>
>             <groupId>org.apache.bval</groupId>
>             <artifactId>org.apache.bval.bundle</artifactId>
>             <scope>compile</scope>
>         </dependency>
>     </dependencies>
> The target file is OK except I need to mark somehow whether bundle is dependency or not.
> dependency="true">mvn:org.apache.geronimo.specs/geronimo-validation_1.1_spec</bundle>
> I think maven runtime scope would be nice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)