[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Replace deprecated ProcessingTime with ProcessingTimeTrigger and hide from end users
URL: https://github.com/apache/spark/pull/24996#discussion_r300811884
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Triggers.scala
 ##########
 @@ -27,3 +32,34 @@ import org.apache.spark.sql.streaming.Trigger
 @Experimental
 @Evolving
 case object OneTimeTrigger extends Trigger
+
+/**
+ * A [[Trigger]] that runs a query periodically based on the processing time. If `interval` is 0,
+ * the query will run as fast as possible.
+ */
+@Evolving
+private[sql] case class ProcessingTimeTrigger(intervalMs: Long) extends Trigger {
 
 Review comment:
   Could you put this into another file like `ContinuousTrigger.scala` and the previous `ProcessingTime.scala`?
   If possible, please do `git mv` for renaming `ProcessingTime` to `ProcessingTimeTrigger`. Then, update the new file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org