You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "rzo1 (via GitHub)" <gi...@apache.org> on 2025/04/29 18:37:12 UTC
[PR] GERONIMO-6883 - Fix 3rd party content. Upgrade to bootstrap 5 [geronimo-website]
rzo1 opened a new pull request, #3:
URL: https://github.com/apache/geronimo-website/pull/3
as the title says
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GERONIMO-6883 - Fix 3rd party content. Upgrade to bootstrap 5 [geronimo-website]
Posted by "fpapon (via GitHub)" <gi...@apache.org>.
fpapon merged PR #3:
URL: https://github.com/apache/geronimo-website/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GERONIMO-6883 - Fix 3rd party content. Upgrade to bootstrap 5 [geronimo-website]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3:
URL: https://github.com/apache/geronimo-website/pull/3#issuecomment-2839947363
Those libs are dropped as not needed with Bootstrap 5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GERONIMO-6883 - Fix 3rd party content. Upgrade to bootstrap 5 [geronimo-website]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #3:
URL: https://github.com/apache/geronimo-website/pull/3#discussion_r2067176493
##########
index.html:
##########
@@ -224,34 +234,33 @@ <h2>Apache & OpenSource</h2>
</div>
</div>
-
+
</main>
-<footer class="text-muted bg-dark">
- <div class="container mb-5">
- <p class="float-right">
- <a href="https://www.apache.org/events/current-event.html" target="_blank">
- <img class="img-fluid mx-auto" src="https://www.apache.org/events/current-event-125x125.png" alt="ApacheEvents" />
- </a>
- </p>
- <p>
- <a target="_blank" href="https://www.apache.org/events/current-event.html" title="Apache Events">Apache Events</a> -
- <a target="_blank" href="https://www.apache.org/licenses/" title="Licenses">Licenses</a> -
- <a target="_blank" href="https://www.apache.org/security/" title="Security">Security</a> -
- <a target="_blank" href="https://www.apache.org/foundation/sponsorship.html" title="Sponsorship">Sponsorship</a> -
- <a target="_blank" href="https://www.apache.org/foundation/thanks.html" title="Thanks">Thanks</a><br/>
- </p>
- <p>
- Copyright © 2020 The Apache Software Foundation, Licensed under the Apache License, Version 2.0.
- </p>
- <p>
- Apache Geronimo, Apache and the Apache feather logo are trademarks of <a href="https://www.apache.org/">The Apache Software Foundation</a>.
- </p>
- </div>
-</footer>
+ <footer class="text-white bg-dark">
+ <div class="container mb-5">
+ <p class="float-end">
+ <a href="https://www.apache.org/events/current-event.html" target="_blank" rel="noopener noreferrer">
+ <img class="img-fluid mx-auto" src="https://www.apache.org/events/current-event-125x125.png" alt="Apache Events" />
+ </a>
+ </p>
+ <p>
+ <a target="_blank" href="https://www.apache.org/events/current-event.html" title="Apache Events" rel="noopener noreferrer" class="text-white">Apache Events</a> -
+ <a target="_blank" href="https://www.apache.org/licenses/" title="Licenses" rel="noopener noreferrer" class="text-white">Licenses</a> -
+ <a target="_blank" href="https://www.apache.org/security/" title="Security" rel="noopener noreferrer" class="text-white" >Security</a> -
+ <a target="_blank" href="https://www.apache.org/foundation/sponsorship.html" title="Sponsorship" rel="noopener noreferrer" class="text-white">Sponsorship</a> -
+ <a target="_blank" href="https://www.apache.org/foundation/thanks.html" title="Thanks" rel="noopener noreferrer" class="text-white">Thanks</a>
+ </p>
+ <p>
+ © 2025 The Apache Software Foundation. Licensed under the Apache License, Version 2.0.
+ </p>
+ <p>
+ Apache Geronimo, Apache, and the Apache feather logo are trademarks of
+ <a href="https://www.apache.org/" target="_blank" rel="noopener noreferrer" class="text-white">The Apache Software Foundation</a>.
+ </p>
+ </div>
+ </footer>
-<script src="https://code.jquery.com/jquery-3.4.1.slim.min.js" integrity="sha384-J6qa4849blE2+poT4WnyKhv5vZF5SrPo0iEjwBvKU7imGFAV0wwj1yYfoRSJoZ+n" crossorigin="anonymous"></script>
Review Comment:
@sebbASF dropped in this PR since not needed with Bootstrap 5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GERONIMO-6883 - Fix 3rd party content. Upgrade to bootstrap 5 [geronimo-website]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #3:
URL: https://github.com/apache/geronimo-website/pull/3#discussion_r2067176493
##########
index.html:
##########
@@ -224,34 +234,33 @@ <h2>Apache & OpenSource</h2>
</div>
</div>
-
+
</main>
-<footer class="text-muted bg-dark">
- <div class="container mb-5">
- <p class="float-right">
- <a href="https://www.apache.org/events/current-event.html" target="_blank">
- <img class="img-fluid mx-auto" src="https://www.apache.org/events/current-event-125x125.png" alt="ApacheEvents" />
- </a>
- </p>
- <p>
- <a target="_blank" href="https://www.apache.org/events/current-event.html" title="Apache Events">Apache Events</a> -
- <a target="_blank" href="https://www.apache.org/licenses/" title="Licenses">Licenses</a> -
- <a target="_blank" href="https://www.apache.org/security/" title="Security">Security</a> -
- <a target="_blank" href="https://www.apache.org/foundation/sponsorship.html" title="Sponsorship">Sponsorship</a> -
- <a target="_blank" href="https://www.apache.org/foundation/thanks.html" title="Thanks">Thanks</a><br/>
- </p>
- <p>
- Copyright © 2020 The Apache Software Foundation, Licensed under the Apache License, Version 2.0.
- </p>
- <p>
- Apache Geronimo, Apache and the Apache feather logo are trademarks of <a href="https://www.apache.org/">The Apache Software Foundation</a>.
- </p>
- </div>
-</footer>
+ <footer class="text-white bg-dark">
+ <div class="container mb-5">
+ <p class="float-end">
+ <a href="https://www.apache.org/events/current-event.html" target="_blank" rel="noopener noreferrer">
+ <img class="img-fluid mx-auto" src="https://www.apache.org/events/current-event-125x125.png" alt="Apache Events" />
+ </a>
+ </p>
+ <p>
+ <a target="_blank" href="https://www.apache.org/events/current-event.html" title="Apache Events" rel="noopener noreferrer" class="text-white">Apache Events</a> -
+ <a target="_blank" href="https://www.apache.org/licenses/" title="Licenses" rel="noopener noreferrer" class="text-white">Licenses</a> -
+ <a target="_blank" href="https://www.apache.org/security/" title="Security" rel="noopener noreferrer" class="text-white" >Security</a> -
+ <a target="_blank" href="https://www.apache.org/foundation/sponsorship.html" title="Sponsorship" rel="noopener noreferrer" class="text-white">Sponsorship</a> -
+ <a target="_blank" href="https://www.apache.org/foundation/thanks.html" title="Thanks" rel="noopener noreferrer" class="text-white">Thanks</a>
+ </p>
+ <p>
+ © 2025 The Apache Software Foundation. Licensed under the Apache License, Version 2.0.
+ </p>
+ <p>
+ Apache Geronimo, Apache, and the Apache feather logo are trademarks of
+ <a href="https://www.apache.org/" target="_blank" rel="noopener noreferrer" class="text-white">The Apache Software Foundation</a>.
+ </p>
+ </div>
+ </footer>
-<script src="https://code.jquery.com/jquery-3.4.1.slim.min.js" integrity="sha384-J6qa4849blE2+poT4WnyKhv5vZF5SrPo0iEjwBvKU7imGFAV0wwj1yYfoRSJoZ+n" crossorigin="anonymous"></script>
Review Comment:
@sebbASF dropped in this PR since not needed with Bootstrap 5? (similar for Popper)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GERONIMO-6883 - Fix 3rd party content. Upgrade to bootstrap 5 [geronimo-website]
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #3:
URL: https://github.com/apache/geronimo-website/pull/3#discussion_r2067176493
##########
index.html:
##########
@@ -224,34 +234,33 @@ <h2>Apache & OpenSource</h2>
</div>
</div>
-
+
</main>
-<footer class="text-muted bg-dark">
- <div class="container mb-5">
- <p class="float-right">
- <a href="https://www.apache.org/events/current-event.html" target="_blank">
- <img class="img-fluid mx-auto" src="https://www.apache.org/events/current-event-125x125.png" alt="ApacheEvents" />
- </a>
- </p>
- <p>
- <a target="_blank" href="https://www.apache.org/events/current-event.html" title="Apache Events">Apache Events</a> -
- <a target="_blank" href="https://www.apache.org/licenses/" title="Licenses">Licenses</a> -
- <a target="_blank" href="https://www.apache.org/security/" title="Security">Security</a> -
- <a target="_blank" href="https://www.apache.org/foundation/sponsorship.html" title="Sponsorship">Sponsorship</a> -
- <a target="_blank" href="https://www.apache.org/foundation/thanks.html" title="Thanks">Thanks</a><br/>
- </p>
- <p>
- Copyright © 2020 The Apache Software Foundation, Licensed under the Apache License, Version 2.0.
- </p>
- <p>
- Apache Geronimo, Apache and the Apache feather logo are trademarks of <a href="https://www.apache.org/">The Apache Software Foundation</a>.
- </p>
- </div>
-</footer>
+ <footer class="text-white bg-dark">
+ <div class="container mb-5">
+ <p class="float-end">
+ <a href="https://www.apache.org/events/current-event.html" target="_blank" rel="noopener noreferrer">
+ <img class="img-fluid mx-auto" src="https://www.apache.org/events/current-event-125x125.png" alt="Apache Events" />
+ </a>
+ </p>
+ <p>
+ <a target="_blank" href="https://www.apache.org/events/current-event.html" title="Apache Events" rel="noopener noreferrer" class="text-white">Apache Events</a> -
+ <a target="_blank" href="https://www.apache.org/licenses/" title="Licenses" rel="noopener noreferrer" class="text-white">Licenses</a> -
+ <a target="_blank" href="https://www.apache.org/security/" title="Security" rel="noopener noreferrer" class="text-white" >Security</a> -
+ <a target="_blank" href="https://www.apache.org/foundation/sponsorship.html" title="Sponsorship" rel="noopener noreferrer" class="text-white">Sponsorship</a> -
+ <a target="_blank" href="https://www.apache.org/foundation/thanks.html" title="Thanks" rel="noopener noreferrer" class="text-white">Thanks</a>
+ </p>
+ <p>
+ © 2025 The Apache Software Foundation. Licensed under the Apache License, Version 2.0.
+ </p>
+ <p>
+ Apache Geronimo, Apache, and the Apache feather logo are trademarks of
+ <a href="https://www.apache.org/" target="_blank" rel="noopener noreferrer" class="text-white">The Apache Software Foundation</a>.
+ </p>
+ </div>
+ </footer>
-<script src="https://code.jquery.com/jquery-3.4.1.slim.min.js" integrity="sha384-J6qa4849blE2+poT4WnyKhv5vZF5SrPo0iEjwBvKU7imGFAV0wwj1yYfoRSJoZ+n" crossorigin="anonymous"></script>
Review Comment:
@sebbASF dropped in this PR since not needed with Bootstrap 5 (similar for Popper).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GERONIMO-6883 - Fix 3rd party content. Upgrade to bootstrap 5 [geronimo-website]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #3:
URL: https://github.com/apache/geronimo-website/pull/3#issuecomment-2839934437
There are also references to
https://code.jquery.com/jquery-3.4.1.slim.min.js
https://cdn.jsdelivr.net/npm/popper.js@1.16.0/dist/umd/popper.min.js
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org