Re: [PR] KAFKA-18026: KIP-1112, clean up StatefulProcessorNode [kafka]

["ableegoldman (via GitHub)" <gi...@apache.org>]

ableegoldman commented on code in PR #18195:
URL: https://github.com/apache/kafka/pull/18195#discussion_r1900475240


##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/GroupedStreamAggregateBuilder.java:
##########
@@ -97,11 +97,10 @@ <KR, VR> KTable<KR, VR> build(final NamedInternal functionName,
             parentNode = repartitionNode;
         }
 
-        final StatefulProcessorNode<K, V> statefulProcessorNode =
-            new StatefulProcessorNode<>(
+        final ProcessorGraphNode<K, V> statefulProcessorNode =
+            new ProcessorGraphNode<>(
                 aggFunctionName,
-                new ProcessorParameters<>(aggregateSupplier, aggFunctionName),
-                new String[] {storeFactory.storeName()}

Review Comment:
   As a matter of fact, I do exactly this in one of the followup PRs: https://github.com/apache/kafka/pull/18342/files#diff-f3bff5bc56202b353e1715217ebe7fa0c59b3622e3c7c4703f47068cd0803165R70



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org