You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/10/26 20:12:03 UTC
[GitHub] [incubator-mxnet] mozga-intel opened a new pull request #20705: [master][clang-format] Add: break line entry before ternary operator
mozga-intel opened a new pull request #20705:
URL: https://github.com/apache/incubator-mxnet/pull/20705
## Description ##
This pull-request solves a problem with ternary operators.
After:
```cpp
const char* sevstr = (severity == Severity::kINTERNAL_ERROR ? " BUG" :
severity == Severity::kERROR ? " ERROR" :
severity == Severity::kWARNING ? "WARNING" :
severity == Severity::kINFO ? " INFO" :
"UNKNOWN");
```
Before
```cpp
const char* sevstr =
(severity == Severity::kINTERNAL_ERROR ?
" BUG" :
severity == Severity::kERROR ? " ERROR" :
severity == Severity::kWARNING ?
"WARNING" :
severity == Severity::kINFO ? " INFO" : "UNKNOWN");
(*_ostream) << "[" << buf << " " << sevstr << "] " << msg << std::endl;
}
```
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20705: [master][clang-format] Add: break line entry before ternary operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20705:
URL: https://github.com/apache/incubator-mxnet/pull/20705#issuecomment-952286866
Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-gpu, windows-cpu, edge, sanity, unix-cpu, centos-cpu, windows-gpu, miscellaneous, clang, website, unix-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20705: [master][clang-format] Add: break line entry before ternary operator
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20705:
URL: https://github.com/apache/incubator-mxnet/pull/20705#issuecomment-952921365
@mxnet-bot run ci [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20705: [master][clang-format] Add: break line entry before ternary operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20705:
URL: https://github.com/apache/incubator-mxnet/pull/20705#issuecomment-952921445
Jenkins CI successfully triggered : [windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha edited a comment on pull request #20705: [master][clang-format] Add: break line entry before ternary operator
Posted by GitBox <gi...@apache.org>.
szha edited a comment on pull request #20705:
URL: https://github.com/apache/incubator-mxnet/pull/20705#issuecomment-952997929
@barry-jin looks like the link check workflow is running into timeouts. See [this run](https://github.com/apache/incubator-mxnet/runs/4019231769?check_suite_focus=true)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20705: [master][clang-format] Add: break line entry before ternary operator
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20705:
URL: https://github.com/apache/incubator-mxnet/pull/20705#issuecomment-952997929
@barry-jin looks like the link check workflow is running into timeouts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20705: [master][clang-format] Add: break line entry before ternary operator
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20705:
URL: https://github.com/apache/incubator-mxnet/pull/20705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mozga-intel commented on pull request #20705: [master][clang-format] Add: break line entry before ternary operator
Posted by GitBox <gi...@apache.org>.
mozga-intel commented on pull request #20705:
URL: https://github.com/apache/incubator-mxnet/pull/20705#issuecomment-952713717
@mxnet-bot run ci [website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20705: [master][clang-format] Add: break line entry before ternary operator
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20705:
URL: https://github.com/apache/incubator-mxnet/pull/20705#issuecomment-952713835
Jenkins CI successfully triggered : [website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org