[GitHub] [pinot] suddendust commented on a change in pull request #7893: [7338] [WIP] Allow Reloading Segments with Multiple Threads

[GitBox <gi...@apache.org>]

suddendust commented on a change in pull request #7893:
URL: https://github.com/apache/pinot/pull/7893#discussion_r773325269



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/messages/SegmentReloadMessage.java
##########
@@ -49,6 +50,13 @@ public SegmentReloadMessage(@Nonnull String tableNameWithType, @Nullable String
     znRecord.setBooleanField(FORCE_DOWNLOAD_KEY, forceDownload);
   }
 
+  public SegmentReloadMessage(@Nonnull String tableNameWithType, @Nullable String segmentName, boolean forceDownload,
+      int parallelism) {

Review comment:
       @siddharthteotia After some discussion, the conclusion is that there is no point in having yet another param to control the parallelism. Instead, using the existing `_refreshThreadsSemaphore` for this makes sense as reload and refresh are so similar. For each available permit, we reload a segment asynchronously.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org